MWPW-156810: adding caas config change for live CTAs #2707
Conversation
|
This pull request is not passing all required checks. Please see this discussion for information on how to get all checks passing. Inconsistent checks can be manually retried. If a test absolutely can not pass for a good reason, please add a comment with an explanation to the PR. |
| @@ -40,6 +40,7 @@ const defaultConfig = { | |||
| reservoir: { sample: 3, pool: 1000 }, | |||
| ctaAction: '_self', | |||
| additionalRequestParams: {}, | |||
| altCtaOnLive: false | |||
There was a problem hiding this comment.
Comma needed, as ESLint is also suggesting
gmirijan
changed the title
|
@sheridansunier is out on PTO and will be back on 08/20 and add fix then (she doesn't have access to internet on her PTO): The fix she needs is this: I was unable to add fix for her as there are permission issues on her fork. |
gmirijan
changed the title
|
@sanrai you could close this PR and open a new one from your own fork |
|
to clarify it was "reliable access to internet on her pto" - @mokimo the unit tests should be fixed now |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## stage #2707 +/- ##
==========================================
+ Coverage 95.74% 95.89% +0.14%
==========================================
Files 172 173 +1
Lines 45470 45892 +422
==========================================
+ Hits 43537 44007 +470
+ Misses 1933 1885 -48 ☔ View full report in Codecov by Sentry. |
As a Virtual Events Product Manager, I want to have a way for a different destination (e.g anchor link) and CTA copy when an event card is live so that when we use event cards to promote the upcoming homepage schedule, a click to the card will take the user to the specific destination (specifically to the marquee video player on the homepage).
This PR adds the configuration change necessary to facilitate the above in CAAS.
Resolves: MWPW-145727
MWPW-156810
Test URLs: