MWPW-154209 - [hero-marquee] bugs

[ryanmparrish]

Fixed some bugs in the hero-marquee that were found in GPW user testing. These changes address the following.

1. Row type and button variants on con-block rows should style the elements. They are not. ex con-block-row-text (s-body, xl-button, xxxl-heading)
2. :icons: in the main content area not rendering.
3. Update lockup styles from incoming globals.
4. When background image is smaller than 1199px, the image should be forced to display at 100% in tablet view.
5. When CTA is the ONLY element placed in "con block row text," margin top should be removed.
6. Video elements not displaying for mobile or tablet when authored w/ bg-bottom-mobile, bg-top-tablet variants.

Resolves: MWPW-154209

Test URLs:

• Before: https://main--milo--adobecom.hlx.page/drafts/rparrish/hero/hero-bugs?martech=off
• After: https://rparrish-hero-bugz--milo--adobecom.hlx.page/drafts/rparrish/hero/hero-bugs?martech=off

Prod URLs:

• Before: https://main--milo--adobecom.hlx.page/docs/library/blocks/hero-marquee?martech=off
• After: https://rparrish-hero-bugz--milo--adobecom.hlx.page/docs/library/blocks/hero-marquee?martech=off
• Before: https://main--milo--adobecom.hlx.page/docs/library/kitchen-sink/hero-marquee?martech=off
• After: https://rparrish-hero-bugz--milo--adobecom.hlx.page/docs/library/kitchen-sink/hero-marquee?martech=off

[aem-code-sync]

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

• Re-run PSI checks
• Re-sync branch

Commits

• 9bff24f ✅ (latest)
• 17d4f6c ✅
• 2b259e2 ✅
• 396930e ✅
• 26c3c58 ✅
• 785f38f ✅
• 6b9d804 ✅
• c6d9cc5 ✅
• c5e717f ✅
• dddcfaa ✅

[aem-code-sync]

	Page	Scores	Audits	Google
M	/docs/library/blocks/hero-marquee?martech=off
D	/docs/library/blocks/hero-marquee?martech=off
M	/docs/library/kitchen-sink/hero-marquee?martech=off
D	/docs/library/kitchen-sink/hero-marquee?martech=off
M	/drafts/rparrish/hero/hero-bugs?martech=off
D	/drafts/rparrish/hero/hero-bugs?martech=off

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.91%. Comparing base (60cb005) to head (9bff24f).
Report is 49 commits behind head on stage.

Additional details and impacted files

@@            Coverage Diff             @@
##            stage    #2727      +/-   ##
==========================================
+ Coverage   95.75%   95.91%   +0.15%     
==========================================
  Files         173      173              
  Lines       45733    45874     +141     
==========================================
+ Hits        43791    43998     +207     
+ Misses       1942     1876      -66     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[colloyd]

@ryanmparrish Looks good, though I noticed in the example for cta as the only element, that the gap between the buttons seems to have been lost - was that on purpose?

[ryanmparrish]

@colloyd - No, thats not intended. Good eye, I see whats going on and will get a fix in asap.

[ryanmparrish]

@colloyd Ok, I addressed that - For those interested in the what/why... I check for rows w/ out <p> tags (minimal content) and wrap them in a <p> so they all get decorated the same and can applyTextOverrides. This should happen before decorating the buttons.

[colloyd]

Looks good now.

[overmyheadandbody]

I think this can lead to some Kodiak alerts, can we use another strategy?

[ryanmparrish]

@overmyheadandbody - I made a few adjustments from your feedback. Thanks for the look and LMK if you have anything else.

[overmyheadandbody]

Thanks for addressing those!

[ryanmparrish]

FYI, i was doing some testing w/ GWP and found one issue im addressing now. When a row-lockup type is used it doesn't fetch the required iconography.css. Ill get an update asap and remove the do-not-merge label. Thanks

https://rparrish-hero-bugz--milo--adobecom.hlx.page/drafts/rparrish/marquee/hero-lockup-row
vs
https://rparrish-hero-bugz--milo--adobecom.hlx.page/drafts/rparrish/marquee/hero-lockup-copy

[ryanmparrish]

FYI - This ^ has been addressed. Carry on

[github-actions]

This PR is currently in the needs-verification state. Please assign a QA engineer to verify the changes.

[NadiiaSokolova]

Verified. Ready for Stage.
Testing details https://jira.corp.adobe.com/browse/MWPW-154209