Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MWPW-148140] Adjust table strikethrough pricing #2786

Merged
merged 1 commit into from
Sep 2, 2024

Conversation

Copy link

codecov bot commented Aug 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.90%. Comparing base (d90dcc0) to head (92a6ced).

Additional details and impacted files
@@            Coverage Diff             @@
##            stage    #2786      +/-   ##
==========================================
- Coverage   95.90%   95.90%   -0.01%     
==========================================
  Files         173      173              
  Lines       45842    45842              
==========================================
- Hits        43967    43964       -3     
- Misses       1875     1878       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@colloyd colloyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simple enough.

@overmyheadandbody
Copy link
Contributor Author

overmyheadandbody commented Aug 26, 2024

FYI, PSI checks are failing due to the fact that the "parent" feature branch, table-review, hasn't been merged in yet. That branch contains enhancements that improve the LH scores.

Copy link
Contributor

This pull request is not passing all required checks. Please see this discussion for information on how to get all checks passing. Inconsistent checks can be manually retried. If a test absolutely can not pass for a good reason, please add a comment with an explanation to the PR.

@SilviuLCF SilviuLCF self-requested a review August 27, 2024 14:22
Copy link

@SilviuLCF SilviuLCF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

@robert-bogos robert-bogos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@milo-pr-merge
Copy link
Contributor

milo-pr-merge bot commented Aug 31, 2024

Skipped merging 2786: [MWPW-148140] Adjust table strikethrough pricing due to failing checks

2 similar comments
@milo-pr-merge
Copy link
Contributor

milo-pr-merge bot commented Sep 1, 2024

Skipped merging 2786: [MWPW-148140] Adjust table strikethrough pricing due to failing checks

@milo-pr-merge
Copy link
Contributor

milo-pr-merge bot commented Sep 2, 2024

Skipped merging 2786: [MWPW-148140] Adjust table strikethrough pricing due to failing checks

@mokimo mokimo merged commit 3331e11 into adobecom:stage Sep 2, 2024
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants