Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v1.109.0 - stagingmaster #10041

Merged
merged 48 commits into from
Jan 8, 2024
Merged

Release v1.109.0 - stagingmaster #10041

merged 48 commits into from
Jan 8, 2024

Conversation

bnussman-akamai
Copy link
Member

Cloud Manager

[2024-01-08] - v1.109.0

Changed:

  • Improve layout of User Permissions page (#10005)
  • Update toast notifications for UserPermissions (#10011)
  • VLAN availability text on Linode Create (#9989)
  • Default access to None for all scopes when creating Personal Access Tokens (#9992)
  • Filter already assigned services from firewall dropdowns (#9993)

Fixed:

  • User Permissions toggle and radio button accessibility (#10009)

Tech Stories:

  • Currency and DateTimeDisplay v7 storybook migrations (#10007)
  • ColorPalette and CircleProgress v7 storybook migration (#10015)
  • DebouncedSearchTextfield and EditableText v7 storybook migrations (#10017)
  • Placeholder and EntityDetails v7 storybook migrations (#10019)
  • PaginationControls V7 story migration (#9959)
  • TagsInput & TagsPanel Storybook v7 Stories (#9963)
  • Add Lint Github Action (#9973)
  • Complete @mui/styles to tss-react migration and remove @mui/styles (#9978)
  • ErrorState and FileUploader v7 storybook migrations (#9981)
  • Speed up code coverage Github Actions jobs by skipping Cloud Manager build (#9988)
  • Radio and TextField v7 storybook migrations (#9994)
  • Graphs stories v7 migration (#9999)
  • Add ability to pass headers to useProfile query (#9987)

Tests:

  • Add Cypress test for Firewalls empty state landing page (#10000)
  • Add integration test for Domains empty landing page (#10004)
  • Add Cypress integration tests for User Permissions page (#10009)
  • Fix CreditCard.test.tsx failing unit test triggered by new year (#10023)
  • Add integration test for AGLB Load Balancer delete flows. (#9955)
  • Add Cypress test for Volumes empty state landing page (#9995)
  • Tests to power on/off and reboot Linodes (#9980)

Upcoming Features:

  • Add child access user permissions for parent accounts (#10005)
  • Update top menu for parent, child, and proxy accounts (#10014)
  • Add AGLB Service Target Section to Full Create Flow (#9965)
  • Change AGLB Rule Session Stickiness unit from milliseconds to seconds (#9969)
  • Improve AGLB selects and other UX (#9975)
  • Ability to choose a single Compute Region ID (e.g., us-east) in Create Object Storage Bucket drawer (#9976)
  • Add mocks and update queries for new Parent/Child endpoints (#9977)
  • Replace NodeBalancer detail charts with Recharts (#9983)
  • Revised copy for Private IP add-on in Linode Create flow (#9990)
  • Add child_account oauth scope to Personal Access Token drawers (#9992)
  • Add AGLB Routes section of full create page (#9997)

API-v4

[2024-01-08] - v0.107.0

Added:

  • Optional headers to getProfile function (#9987)

Tech Stories:

  • Add Lint GitHub Action (#9973)

Validation

[2024-01-08] - v0.37.0

Tech Stories:

  • Add Lint Github Action (#9973)

coliu-akamai and others added 30 commits December 8, 2023 18:00
* pagination story

* update comments and tests

* changeset

* fix page arg not taking effect

* Update packages/manager/src/components/PaginationControls/PaginationControls.stories.tsx

Co-authored-by: Banks Nussman <115251059+bnussman-akamai@users.noreply.github.com>

* update import

---------

Co-authored-by: Banks Nussman <115251059+bnussman-akamai@users.noreply.github.com>
… Forms (#9975)

* add context to select options

* fix aglb e2e tests

* Added changeset: Improve AGLB selects and other UX

---------

Co-authored-by: Banks Nussman <banks@nussman.us>
…ld endpoints (#9977)

* WIP

* Allow unrestricted parent users to access the new endpoints

* Clean up comments

* Mock company names, not person names, for child accounts

* Revert unintended change

* Add changeset

* Add mock expiry
* update vite and vitest major versions

* try to get e2es to run

* get eslint to run

* correct path

* bump versions for vitest bug

---------

Co-authored-by: Banks Nussman <banks@nussman.us>
…nds instead of Milliseconds (#9969)

* use seconds, disabled save if no changes were made in edit mode

* Added changeset: Change AGLB Rule Session Stickiness unit from milliseconds to seconds

* add unit tests

---------

Co-authored-by: Banks Nussman <banks@nussman.us>
* add lint step for Cloud Manager

* don't lint storybook build js and fix eslint error

* try linting all packages

* clean up strings

* add changesets

---------

Co-authored-by: Banks Nussman <banks@nussman.us>
* only build code needed to run the unit tests

* Added changeset: Speed up code coverage Github Actions jobs by skipping Cloud Manager build

---------

Co-authored-by: Banks Nussman <banks@nussman.us>
* add paper and table

* working flow

* improve UX

* add testing

* Added changeset: Add AGLB Service Target Section to Full Create Flow

* feedback @mjac0bs

* more feedback (hide CA for not https and add tooltip) @mjac0bs

* Update packages/validation/src/loadbalancers.schema.ts

Co-authored-by: Mariah Jacobs <114685994+mjac0bs@users.noreply.github.com>

* make stepper clickable

* clean up and hook up `Add Another Configuration`

* add filtering

---------

Co-authored-by: Banks Nussman <banks@nussman.us>
Co-authored-by: Mariah Jacobs <114685994+mjac0bs@users.noreply.github.com>
…flows (#9955)

* Create mockDeleteLoadBalancer and mockDeleteLoadBalancerError

* Deletes Loadbalancer from landing page

* Deletes Loadbalancer from Settings tab

* code cleanup

* Added changeset: Add integration test for AGLB Load Balancer delete flows.

* Validate error handling while deleting loadbalancer

* PR - feedback
refactor: [M3-7542] - TagsInput & TagsPanel Storybook v7 Stories
Co-authored-by: Banks Nussman <banks@nussman.us>
…te (#9995)

* test: [M3-7470] - Add Cypress test for Volumes landing page empty state

* Add changeset
#9983)

## Description 📝
This PR is part of a bigger effort to replace chart.js with the more modern Recharts. 

## Changes  🔄
List any change relevant to the reviewer.
- Replace the NodeBalancer details page charts with Recharts
- Refactor code to use one AreaChart component

## How to test 🧪

### Prerequisites
(How to setup test environment)
- Have a NodeBalancer that's been running for a while

### Verification steps 
(How to verify changes)
- Go to the Network tab of a NodeBalancer that's been running for a while
  - Confirm the updated UI and that there are no regressions in the graph, units, etc
- Confirm there are no regressions in the Linode Network Transfer History chart from the refactoring
* Initial commit - save work

* Replace long list with tooltip content

* Test part 1

* Test part 1

* Test part 2

* Delete packages/manager/src/features/Linodes/LinodesCreate/VlanAvailabilityNotice.tsx

* Added changeset: VLAN availability text on Linode Create
* stories

* add tests

* Added changeset: Radio and TextField v7 storybook migrations
* finish migration with codemod

* remove commit

* rewrite enzyme test

* fix: kubernetes node pool drawer width @coliu-akamai

* fix order styles are applied to fix secret download icon

* clean up

* change `Learn More` to `Learn more`

* make MetricsDisplay look a lot less broken

* Added changeset: Complete @mui/styles to tss-react migration and remove @mui/styles

* fix Linode and NodeBalancer summaries

* make Node Pool Drawer width match production

* fix longview to the best of my ability

* So long old `Grid`s

---------

Co-authored-by: Banks Nussman <banks@nussman.us>
Co-authored-by: Alban Bailly <abailly@akamai.com>
* added an empty object to all useAccount instances

* Added changeset: Add setHeaders to GET account/ endpoint

* fix query enable so that it accepts all types of users

* added unit test but is failing

* added unit tests but failing

* added server.use

* fixed unit tests

* removed unit test and made useAccount param optional

* fixed error in useInitialRequests

* swapped useAccount to useProfile

* Update pr-9987-upcoming-features-1702333742297.md

* reverted changes to useAccount

* Use this to test PR

* reverted test code

* Use this to test PR

* reverted test commit

* addressed optional param feedback

* Added changeset: Add setHeaders to GET profile/ endpoint

* Update changeset from upcomming feature to added

* potential fix for e2e test fails

* potential e2e test fix
…#9982)

* converted stories and added test

* moving around a lot of stuff for better organization??

* update imports

* stories

* tests

* changeset, additional comments

* feedback pass 1

* feedback round 2
* test: [M3-7464] - Add Cypress test FW landing page empty state

* Add changeset
…tion (#10007)

* storybook and additional tests

* changeset
mjac0bs and others added 15 commits December 20, 2023 07:26
… and View PAT drawers (#9992)

* Add child_account scope to Create and View PAT drawers

* Make new scope name match mocks

* Fix APITokens utils failing tests

* Fix one failing unit test with await

* Update comment

* Fix the unit tests for real, hopefully

* Mock the useAccountUser hook in test, thanks @jdamore-linode

* Update test for View PAT drawer

* Clean up

* Added changeset: Add `child_account` oauth scope to Personal Access Token drawers

* More test clean up

* Address feedback: clean up filtering in return statement

* Default access to None rather than ReadWrite when creating a PAT
…ations (#10015)

* circle progress story and test

* color palette

* Added changeset: ColorPalette and CircleProgress v7 storybook migration

* update color palette test
…10011)

* updated toast notifications for UserPermissions

* Added changeset: Update toast notifications for UserPermissions

* added user permissions
…page (#10009)

* Add mock utils related to user permission and grant management

* Add array shuffle util

* Add account access toggle ARIA label

* Improve QA attributes for billing access selection

* WIP add user permission management tests

* Add ARIA labels for entity-specific user permissions radio buttons

* Add assertions for entity-specific section

* Add changesets

* Update toast messages to reflect toasts in PR #10011

---------

Co-authored-by: mjac0bs <mjacobs@akamai.com>
…orybook migrations (#10017)

* editable text

* update comment

* debounced search storybook

* tests for debounced search text field

* Added changeset: DebouncedSearchTextfield and EditableText v7 storybook migrations

* removed file

* Update packages/manager/src/components/DebouncedSearchTextField/DebouncedSearchTextField.tsx

Co-authored-by: Banks Nussman <115251059+bnussman-akamai@users.noreply.github.com>

* Do a little unit test clean up for readability

---------

Co-authored-by: Banks Nussman <115251059+bnussman-akamai@users.noreply.github.com>
Co-authored-by: mjac0bs <mjacobs@akamai.com>
…unts (#10005)

* initial commit

* removed unrestricted render

* layout improvements

* Added changeset: Add child access user permissions for parent accounts

* placed toggle behind feature flag and enabled it for specific scenerios listed in the PR description

* invalidated account query so Account access column gets updated

* fixed mobil breakpoint

* fixed mobil breakpoint pt2

* updated styling and mocks

* fixed styling for Loading Circle

* fixed global perm name to match GlobalGrantTypes

* fixed toggle description

* specified mock account name, cleaned up code, fixed error

* Update pr-10005-changed-1702679066439.md

* Added changeset: Add child access user permissions for parent accounts

* added upcomming changeset

* add test id back to typography

* e2e test still failing

* fixed e2e tests
…drawers (#9993)

* initial commit for filtering out already assigned services

* Added changeset: Filter already assigned services from firewall dropdowns

* invalidated queries

* fixed unit tests

* fixed unit tests
…ations (#10019)

* placeholder

* entity details

* add comment

* Added changeset: PLaceholder and EntityDetails v7 storybook migrations

* Fix typo in changeset; tiny bit of clean up in test

---------

Co-authored-by: mjac0bs <mjacobs@akamai.com>
)

* M3-6608 Add Linode power off, power on and reboot tests

* Added changeset: Tests to power on/off and reboot Linodes
* mock luxon date before testing

* add comments

* improve naming and make code more clear

* Added changeset: Fix `CreditCard.test.tsx` failing unit test

---------

Co-authored-by: Banks Nussman <banks@nussman.us>
…counts (#10014)

* Add company name and username by user type to top menu

* Feature flag the menu change

* Add WIP unit tests

* Add unit test cases for different user types

* Clean up

* Clean up 2

* Add changeset

* Fix ticket # typo in comment

* Improve styling

* Clean up 3

* Address feedback: clean up axios header token arg
… Region ID eg ('us-east') (#9976)

* upcoming: [M3-7423] - Show regions instead of clusterIds in Create Drawer

* Revert "upcoming: [M3-7423] - Show regions instead of clusterIds in Create Drawer"

This reverts commit be7305b.

* Create Regions field for Create Bucket Drawer

* Test coverage BucketRegions

* Update CreateBucketSchema.

* Update object-storage types for create bucket flow

* Add CreateBucketDrawerObjMultiCluster

* Add OBJ Multi-Cluster account level capability

* Update ObjectStorageLanding.tsx

* Added changeset: Create Bucket flow - Able to choose a single Compute Region ID eg ('us-east')

* Update packages/api-v4/src/object-storage/types.ts

Co-authored-by: Dajahi Wiley <114682940+dwiley-akamai@users.noreply.github.com>

* Update packages/manager/.changeset/pr-9976-upcoming-features-1702579922373.md

Co-authored-by: Dajahi Wiley <114682940+dwiley-akamai@users.noreply.github.com>

* Update packages/manager/src/features/ObjectStorage/BucketLanding/CreateBucketDrawerObjMultiCluster.tsx

Co-authored-by: Dajahi Wiley <114682940+dwiley-akamai@users.noreply.github.com>

* Update packages/manager/src/features/ObjectStorage/BucketLanding/BucketRegions.tsx

Co-authored-by: Dajahi Wiley <114682940+dwiley-akamai@users.noreply.github.com>

* PR - Feedback - sorted alphabetically

* PR - feedback - rename file name and decouple styles.

* Update formatRegion.ts

* Update types.ts

* Resolve duplicated keys console errors when MSW enabled.

* adjust tests

* Update Cypress tests

* Show required label for Autocomplete field.

---------

Co-authored-by: Dajahi Wiley <114682940+dwiley-akamai@users.noreply.github.com>
…y PAT creation (#10040)

* fix profile query keys

* add extra bug fix

* Fix loading state for User Permissions page

* fix two factor invalidation

* use `null` insted of empty object

* Fix error for RO PAT creation

---------

Co-authored-by: Banks Nussman <banks@nussman.us>
Co-authored-by: mjac0bs <mjacobs@akamai.com>
Release v1.109.0 - `release` → `staging`
@bnussman-akamai bnussman-akamai added the Release Cloud Manager releases label Jan 8, 2024
@bnussman-akamai bnussman-akamai self-assigned this Jan 8, 2024
@bnussman-akamai bnussman-akamai requested review from a team as code owners January 8, 2024 20:11
Copy link

cypress bot commented Jan 8, 2024

1 failed test on run #5545 ↗︎

1 286 0 0 Flakiness 0

Details:

Merge pull request #10030 from linode/release-v1.109.0
Project: Cloud Manager E2E Commit: ac2d49ed9f
Status: Failed Duration: 18:48 💡
Started: Jan 8, 2024 8:13 PM Ended: Jan 8, 2024 8:31 PM
Failed  cypress/e2e/core/vpc/vpc-linodes-update.spec.ts • 1 failed test

View Output Video

Test Artifacts
VPC assign/unassign flows > can assign Linode(s) to a VPC Screenshots Video

Review all test suite changes for PR #10041 ↗︎

Copy link
Contributor

@dwiley-akamai dwiley-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

Copy link
Contributor

@mjac0bs mjac0bs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

I checked the Changed/Fixed updates and basic functionality for most products (linode, nodebalancer, volume, OBJ, kube) and compared with prod to check for visual regressions.

The one failing e2e spec passes locally -- I think I've seen this one fail in CI before, might be worth a ticket to look into if we don't already have one:
image

Copy link
Contributor

@jaalah-akamai jaalah-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@bnussman-akamai bnussman-akamai merged commit 36cc200 into master Jan 8, 2024
36 of 40 checks passed
@jaalah-akamai jaalah-akamai changed the title Release v1.109.0 - staging → master Release v1.109.0 - stagingmaster Feb 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Release Cloud Manager releases
Projects
None yet
Development

Successfully merging this pull request may close these issues.