Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: [M3-7464] - Add Cypress test FW landing page empty state #10000

Merged
merged 2 commits into from
Dec 19, 2023

Conversation

carrillo-erik
Copy link
Contributor

@carrillo-erik carrillo-erik commented Dec 14, 2023

Description 📝

Introduces Cypress tests for the Firewalls landing page in an empty state (no firewalls exist).

Changes 🔄

  • The tests verify that the empty state works as expected.

Preview 📷

Screenshot 2023-12-14 at 1 54 48 PM

How to test 🧪

  • Run yarn cy:run -s "cypress/e2e/core/firewalls/landing-page-empty-state.spec.ts"

Verification steps

  • Verify e2e test passes.

As an Author I have considered 🤔

  • 👀 Doing a self review
  • ❔ Our contribution guidelines
  • 🤏 Splitting feature into small PRs
  • ➕ Adding a changeset
  • 🧪 Providing/Improving test coverage
  • 🔐 Removing all sensitive information from the code and PR description
  • 🚩 Using a feature flag to protect the release
  • 👣 Providing comprehensive reproduction steps
  • 📑 Providing or updating our documentation
  • 🕛 Scheduling a pair reviewing session
  • 📱 Providing mobile support
  • ♿ Providing accessibility support

@carrillo-erik carrillo-erik self-assigned this Dec 14, 2023
@carrillo-erik carrillo-erik requested a review from a team as a code owner December 14, 2023 21:56
@carrillo-erik carrillo-erik requested review from cliu-akamai and removed request for a team December 14, 2023 21:56
@carrillo-erik carrillo-erik requested a review from a team as a code owner December 14, 2023 21:58
@carrillo-erik carrillo-erik requested review from jdamore-linode and coliu-akamai and removed request for a team December 14, 2023 21:58
Copy link

github-actions bot commented Dec 14, 2023

Coverage Report:
Base Coverage: 77.29%
Current Coverage: 77.29%

Copy link
Contributor

@coliu-akamai coliu-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

confirmed test passes - thanks Erik!

pr # 10000! woot 🎉

@coliu-akamai coliu-akamai added the Add'tl Approval Needed Waiting on another approval! label Dec 15, 2023
@coliu-akamai coliu-akamai added Approved Multiple approvals and ready to merge! and removed Add'tl Approval Needed Waiting on another approval! labels Dec 19, 2023
@carrillo-erik carrillo-erik merged commit 879bb03 into linode:develop Dec 19, 2023
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved Multiple approvals and ready to merge! Testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants