Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: [M3-7470] - Cypress test for Volumes landing page empty state #9995

Merged
merged 2 commits into from
Dec 13, 2023

Conversation

carrillo-erik
Copy link
Contributor

@carrillo-erik carrillo-erik commented Dec 12, 2023

Description 📝

This PR introduces Cypress tests for the Volumes landing page in an empty state (no volumes exists).

Changes 🔄

  • The tests verify that the empty state works as expected.

Preview 📷

Screenshot 2023-12-12 at 2 21 32 PM

How to test 🧪

  • Run yarn cy:run -s "/Users/ecarrill/Desktop/manager/packages/manager/cypress/e2e/core/volumes/landing-page-empty-state.spec.ts"

Verification steps

  • Verify e2e test passes.

As an Author I have considered 🤔

  • 👀 Doing a self review
  • ❔ Our contribution guidelines
  • 🤏 Splitting feature into small PRs
  • ➕ Adding a changeset
  • 🧪 Providing/Improving test coverage
  • 🔐 Removing all sensitive information from the code and PR description
  • 🚩 Using a feature flag to protect the release
  • 👣 Providing comprehensive reproduction steps
  • 📑 Providing or updating our documentation
  • 🕛 Scheduling a pair reviewing session
  • 📱 Providing mobile support
  • ♿ Providing accessibility support

@carrillo-erik carrillo-erik requested a review from a team as a code owner December 12, 2023 22:23
@carrillo-erik carrillo-erik requested review from jdamore-linode and removed request for a team December 12, 2023 22:23
@carrillo-erik carrillo-erik self-assigned this Dec 12, 2023
@carrillo-erik carrillo-erik requested a review from a team as a code owner December 12, 2023 22:32
@carrillo-erik carrillo-erik requested review from bnussman-akamai and abailly-akamai and removed request for a team December 12, 2023 22:32
Copy link

github-actions bot commented Dec 12, 2023

Coverage Report:
Base Coverage: 78.34%
Current Coverage: 78.34%

Copy link
Contributor

@abailly-akamai abailly-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice thanks for adding this test! ✅

@carrillo-erik carrillo-erik merged commit ea02c3f into linode:develop Dec 13, 2023
17 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants