Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: [M3-7544, M3-7552] - ErrorState and FileUploader v7 stories #9982

Merged
merged 8 commits into from
Dec 18, 2023
Merged

refactor: [M3-7544, M3-7552] - ErrorState and FileUploader v7 stories #9982

merged 8 commits into from
Dec 18, 2023

Conversation

coliu-akamai
Copy link
Contributor

@coliu-akamai coliu-akamai commented Dec 8, 2023 •
edited
Loading

Description 📝

  • Migrate ErrorState component story to a V7 (.tsx) story
  • Migrate FileUploader component story to a V7 (.tsx) story
  • Rearrange FileUploader/ObjectUploader files and storybook
  • Add tests

How to test 🧪

Verification steps

As an Author I have considered 🤔

Check all that apply

  • 👀 Doing a self review
  • ❔ Our contribution guidelines
  • 🤏 Splitting feature into small PRs
  • ➕ Adding a changeset
  • 🧪 Providing/Improving test coverage
  • 🔐 Removing all sensitive information from the code and PR description
  • 🚩 Using a feature flag to protect the release
  • 👣 Providing comprehensive reproduction steps
  • 📑 Providing or updating our documentation
  • 🕛 Scheduling a pair reviewing session
  • 📱 Providing mobile support
  • ♿ Providing accessibility support

@coliu-akamai coliu-akamai self-assigned this Dec 8, 2023
coliu-akamai
coliu-akamai commented Dec 8, 2023
View reviewed changes
packages/manager/src/components/Uploaders/ObjectUploader/ObjectUploader.tsx
@@ -1,4 +1,5 @@
import { getObjectURL } from '@linode/api-v4/lib/object-storage';
import { AxiosProgressEvent } from 'axios';
Copy link
Contributor Author

@coliu-akamai coliu-akamai Dec 8, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moved FileUploader and ObjectUploader into one folder underneath the Components package for organization - both stories were housed under components and they're both file uploaders

If we prefer ObjectUploader to stay underneath features/ObjectStorage I can undo this change. Otherwise, would appreciate name suggestions for the overarching package besides Uploaders 😅

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fine! I also like it here

@coliu-akamai coliu-akamai marked this pull request as ready for review December 8, 2023 18:22
@coliu-akamai coliu-akamai requested a review from a team as a code owner December 8, 2023 18:22
@coliu-akamai coliu-akamai requested review from mjac0bs, bnussman-akamai and abailly-akamai and removed request for a team December 8, 2023 18:22
abailly-akamai
abailly-akamai reviewed Dec 12, 2023
View reviewed changes
Copy link
Contributor

@abailly-akamai abailly-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! those are not simple stories. The uploaders are tricky so let me know if you want to pair up on those.

Left a few comments to clean things up and improve functionality

packages/manager/src/components/ErrorState/ErrorState.stories.tsx Outdated Show resolved Hide resolved
packages/manager/src/components/ErrorState/ErrorState.stories.tsx Show resolved Hide resolved
packages/manager/src/components/ErrorState/ErrorState.test.tsx Outdated Show resolved Hide resolved
packages/manager/src/components/Uploaders/FileUploader/FileUploader.stories.tsx Outdated Show resolved Hide resolved
packages/manager/src/components/Uploaders/FileUploader/FileUploader.stories.tsx Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any way we can make this story "work" as in I can at least place an artifact in the drop zone?

Copy link
Contributor Author

@coliu-akamai coliu-akamai Dec 12, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm seems like this component is actually named inaccurately and should be 'Image Uploader' - I'm able to upload images/.gz files, but nothing else
image

I'm able to put in files for the ObjectUploader, though there's always an error (likely because we're not connected to an actual bucket?).
image

both behaviors match prod. Gonna rename FileUploader.tsx to ImageUploader

packages/manager/src/components/Uploaders/ObjectUploader/ObjectUploader.tsx
@@ -1,4 +1,5 @@
import { getObjectURL } from '@linode/api-v4/lib/object-storage';
import { AxiosProgressEvent } from 'axios';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fine! I also like it here

packages/manager/src/features/ObjectStorage/BucketDetail/BucketDetail.tsx Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 12, 2023 •
edited
Loading

Coverage Report: ✅
Base Coverage: 77.18%
Current Coverage: 77.36%

bnussman-akamai
bnussman-akamai approved these changes Dec 13, 2023
View reviewed changes
Copy link
Member

@bnussman-akamai bnussman-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Confirmed Object Storage and Image uploads still worked as expected.

@coliu-akamai coliu-akamai added Add'tl Approval Needed Waiting on another approval! and removed Ready for Review labels Dec 14, 2023
abailly-akamai
abailly-akamai approved these changes Dec 18, 2023
View reviewed changes
Copy link
Contributor

@abailly-akamai abailly-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for address feedback. This looks good to go! 🚢

@coliu-akamai coliu-akamai added Approved Multiple approvals and ready to merge! and removed Add'tl Approval Needed Waiting on another approval! labels Dec 18, 2023
@coliu-akamai coliu-akamai merged commit 83eab63 into linode:develop Dec 18, 2023
18 checks passed
@coliu-akamai coliu-akamai deleted the storybook-errorstate-fileuploader branch December 19, 2023 04:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bnussman-akamai bnussman-akamai bnussman-akamai approved these changes

@abailly-akamai abailly-akamai abailly-akamai approved these changes

@mjac0bs mjac0bs Awaiting requested review from mjac0bs mjac0bs is a code owner automatically assigned from linode/frontend

Assignees

@coliu-akamai coliu-akamai

Labels
Approved Multiple approvals and ready to merge! Storybook
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@coliu-akamai @bnussman-akamai @abailly-akamai