refactor: [M3-7537] - PaginationControls Storybook v7 Story #9959
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coliu-akamai
requested review from
jdamore-linode,
dwiley-akamai and
abailly-akamai
and removed request for
a team
dwiley-akamai
approved these changes
Dec 7, 2023
| <PaginationControls | ||
| {...args} | ||
| onClickHandler={context.setPage} | ||
| page={context.page} |
There was a problem hiding this comment.
Just noting that the page control doesn't seem to work (it doesn't in prod Storybook either)
Video
Screen.Recording.2023-12-07.at.4.12.44.PM.mov
There was a problem hiding this comment.
👀 hmm wondering if it's because of page={context.page}, so maybe it ignores that argument? will look into it some more
There was a problem hiding this comment.
edit: i think it's because of context.page. When I changed the args object to include page: 1, changing the page control affects the component but then the onClickHandler (context.setPage) doesn't work. Made a controlled pagination example that should work now! ty for catching
coliu-akamai
added
Add'tl Approval Needed
|
Coverage Report: ✅ |
bnussman-akamai
approved these changes
Dec 8, 2023
packages/manager/src/components/PaginationControls/PaginationControls.stories.tsx
Outdated
Show resolved
Hide resolved
bnussman-akamai
added
Approved
…ontrols.stories.tsx Co-authored-by: Banks Nussman <115251059+bnussman-akamai@users.noreply.github.com>
This was referenced Jan 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📝
Changes 🔄
How to test 🧪
Verification steps
yarn test PaginationControlsAs an Author I have considered 🤔
Check all that apply