Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change: [M3-7505] – Update copy for Private IP add-on in Linode Create flow #9990

Merged
merged 2 commits into from
Dec 12, 2023
Merged

change: [M3-7505] – Update copy for Private IP add-on in Linode Create flow #9990

merged 2 commits into from
Dec 12, 2023

Conversation

dwiley-akamai
Copy link
Contributor

Description 📝

Update the descriptive copy for the Private IP add-on in the Linode Create flow.

Changes 🔄

  • Copy change for Private IP add-on in Linode Create flow

How to test 🧪

Prerequisites

  • An account with the proper VPC tags

Verification steps

  • On an account with the proper VPC tags or with the VPC feature flag on, you should see the text for the Private IP add-on in the Linode Create flow

As an Author I have considered 🤔

  • 👀 Doing a self review
  • ❔ Our contribution guidelines
  • 🤏 Splitting feature into small PRs
  • ➕ Adding a changeset
  • 🧪 Providing/Improving test coverage
  • 🔐 Removing all sensitive information from the code and PR description
  • 🚩 Using a feature flag to protect the release
  • 👣 Providing comprehensive reproduction steps
  • 📑 Providing or updating our documentation
  • 🕛 Scheduling a pair reviewing session
  • 📱 Providing mobile support
  • ♿ Providing accessibility support

@dwiley-akamai dwiley-akamai added the VPC Relating to VPC project label Dec 12, 2023
@dwiley-akamai dwiley-akamai self-assigned this Dec 12, 2023
@dwiley-akamai dwiley-akamai requested a review from a team as a code owner December 12, 2023 17:04
@dwiley-akamai dwiley-akamai requested review from jdamore-linode and cpathipa and removed request for a team December 12, 2023 17:04
coliu-akamai
coliu-akamai approved these changes Dec 12, 2023
View reviewed changes
Copy link
Contributor

@coliu-akamai coliu-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

confirmed copy 🚢

@coliu-akamai coliu-akamai added the Add'tl Approval Needed Waiting on another approval! label Dec 12, 2023
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 12, 2023 •
edited
Loading

Coverage Report: ✅
Base Coverage: 77.18%
Current Coverage: 77.18%

@bnussman-akamai bnussman-akamai added Approved Multiple approvals and ready to merge! and removed Add'tl Approval Needed Waiting on another approval! labels Dec 12, 2023
@dwiley-akamai dwiley-akamai merged commit 62a9230 into linode:develop Dec 12, 2023
18 checks passed
@dwiley-akamai dwiley-akamai deleted the M3-7505-private-ip-updated-copy branch December 12, 2023 18:52
This was referenced Jan 4, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bnussman-akamai bnussman-akamai bnussman-akamai approved these changes

@coliu-akamai coliu-akamai coliu-akamai approved these changes

@jdamore-linode jdamore-linode Awaiting requested review from jdamore-linode jdamore-linode is a code owner automatically assigned from linode/frontend

@cpathipa cpathipa Awaiting requested review from cpathipa cpathipa is a code owner automatically assigned from linode/frontend

Assignees

@dwiley-akamai dwiley-akamai

Labels
Approved Multiple approvals and ready to merge! VPC Relating to VPC project
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dwiley-akamai @bnussman-akamai @coliu-akamai @DevDW