refactor: [M3-7575] CircleProgress and ColorPalette storybook v7 migrations #10015
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coliu-akamai
requested review from
bnussman-akamai and
cpathipa
and removed request for
a team
coliu-akamai
commented
Dec 20, 2023
| children?: JSX.Element; | ||
| className?: string; |
There was a problem hiding this comment.
Removing this method of adding additional styles since this prop is never used + we're moving away from classNames. Keeping the other option, sx, as a prop
|
Coverage Report: ✅ |
abailly-akamai
approved these changes
Dec 21, 2023
| const innerCircle = screen.queryByTestId('inner-circle-progress'); | ||
| expect(innerCircle).not.toBeInTheDocument(); | ||
| }); | ||
| }); |
packages/manager/src/components/ColorPalette/ColorPalette.test.tsx
Outdated
Show resolved
Hide resolved
coliu-akamai
added
Add'tl Approval Needed
cpathipa
approved these changes
Dec 21, 2023
coliu-akamai
added
Approved
This was referenced Jan 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📝
How to test 🧪
Verification steps
As an Author I have considered 🤔
Check all that apply