Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: [M3-7135] - Add integration test for AGLB Load Balancer delete flows #9955

Merged
merged 7 commits into from
Dec 12, 2023
Merged

test: [M3-7135] - Add integration test for AGLB Load Balancer delete flows #9955

merged 7 commits into from
Dec 12, 2023

Conversation

cpathipa
Copy link
Contributor

@cpathipa cpathipa commented Dec 4, 2023 •
edited
Loading

Description 📝

Adds more e2e tests for AGLB.

How to test 🧪

  • yarn cy:debug
  • Run load-balancer-summary.spec.ts
  • Run load-balancer-landing-page.spec.ts

As an Author I have considered 🤔

Check all that apply

  • 👀 Doing a self review
  • ❔ Our contribution guidelines
  • 🤏 Splitting feature into small PRs
  • ➕ Adding a changeset
  • 🧪 Providing/Improving test coverage
  • 🔐 Removing all sensitive information from the code and PR description
  • 🚩 Using a feature flag to protect the release
  • 👣 Providing comprehensive reproduction steps
  • 📑 Providing or updating our documentation
  • 🕛 Scheduling a pair reviewing session
  • 📱 Providing mobile support
  • ♿ Providing accessibility support

@cpathipa cpathipa requested a review from a team as a code owner December 4, 2023 12:39
@cpathipa cpathipa requested review from jdamore-linode and removed request for a team December 4, 2023 12:39
@cpathipa cpathipa requested a review from a team as a code owner December 4, 2023 12:40
@cpathipa cpathipa requested review from mjac0bs and abailly-akamai and removed request for a team December 4, 2023 12:40
@cpathipa cpathipa changed the title test: [M3-7132] - Add integration test for AGLB Load Balancer delete flows test: [M3-7135] - Add integration test for AGLB Load Balancer delete flows Dec 4, 2023
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 4, 2023 •
edited
Loading

Coverage Report: ✅
Base Coverage: 77.17%
Current Coverage: 77.17%

@bnussman-akamai bnussman-akamai added e2e Indicates that a PR touches Cypress tests in some way ACLB Relating to the Akamai Cloud Load Balancer labels Dec 4, 2023
abailly-akamai
abailly-akamai approved these changes Dec 5, 2023
View reviewed changes
Copy link
Contributor

@abailly-akamai abailly-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Code looks good to me and tests are passing locally ✅

I would still wait for @jdamore-linode 's review to merge 👍

@coliu-akamai coliu-akamai added the Approved Multiple approvals and ready to merge! label Dec 7, 2023
jdamore-linode
jdamore-linode approved these changes Dec 12, 2023
View reviewed changes
Copy link
Contributor

@jdamore-linode jdamore-linode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work @cpathipa! Had one small suggestion but this looks great!

packages/manager/cypress/e2e/core/loadBalancers/load-balancer-summary.spec.ts Outdated Show resolved Hide resolved
@cpathipa cpathipa merged commit 850d4cc into linode:develop Dec 12, 2023
17 of 18 checks passed
@cpathipa cpathipa deleted the M3-7135 branch December 12, 2023 21:34
This was referenced Jan 4, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdamore-linode jdamore-linode jdamore-linode approved these changes

@bnussman-akamai bnussman-akamai bnussman-akamai approved these changes

@abailly-akamai abailly-akamai abailly-akamai approved these changes

@mjac0bs mjac0bs Awaiting requested review from mjac0bs mjac0bs is a code owner automatically assigned from linode/frontend

Assignees

@cpathipa cpathipa

Labels
ACLB Relating to the Akamai Cloud Load Balancer Approved Multiple approvals and ready to merge! e2e Indicates that a PR touches Cypress tests in some way
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@cpathipa @jdamore-linode @bnussman-akamai @abailly-akamai @coliu-akamai