Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

the big revamp PR! #52

Merged
merged 163 commits into from
Jan 31, 2023
Merged

the big revamp PR! #52

merged 163 commits into from
Jan 31, 2023

Conversation

fivetran-jamie
Copy link
Contributor

@fivetran-jamie fivetran-jamie commented Jan 30, 2023

Are you a current Fivetran customer?

fivetran made PR

What change(s) does this PR introduce?

merges the following PRs

Did you update the CHANGELOG?

  • Yes

Does this PR introduce a breaking change?

  • Yes (please provide breaking change details below.)
  • No (please provide an explanation as to how the change is non-breaking below.)

Did you update the dbt_project.yml files with the version upgrade (please leverage standard semantic versioning)? (In both your main project and integration_tests)

  • Yes

Is this PR in response to a previously created Bug or Feature Request

How did you test the PR changes?

  • Buildkite
  • Local (please provide additional testing details below)

Select which warehouse(s) were used to test the PR

  • BigQuery
  • Redshift
  • Snowflake
  • Postgres
  • Databricks
  • Other (provide details below)

Provide an emoji that best describes your current mood

💃

Feedback

We are so excited you decided to contribute to the Fivetran community dbt package! We continue to work to improve the packages and would greatly appreciate your feedback on our existing dbt packages or what you'd like to see next.

Copy link
Contributor

@fivetran-joemarkiewicz fivetran-joemarkiewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fivetran-jamie this PR looks good to go! I have a few suggestions to be added. Once those are added, and the PR #50 is merged into here then this will be good to go!

Additionally, be sure to regenerate the docs one last time before merging. I also made a few minor updates in two previous commits to address merge conflicts with main and get integration tests to pass.

models/stg_shopify.yml Outdated Show resolved Hide resolved
models/stg_shopify.yml Outdated Show resolved Hide resolved
models/stg_shopify.yml Outdated Show resolved Hide resolved
models/stg_shopify.yml Outdated Show resolved Hide resolved
models/stg_shopify.yml Outdated Show resolved Hide resolved
models/stg_shopify.yml Outdated Show resolved Hide resolved
models/stg_shopify.yml Outdated Show resolved Hide resolved
models/stg_shopify.yml Outdated Show resolved Hide resolved
models/stg_shopify.yml Outdated Show resolved Hide resolved
models/stg_shopify.yml Outdated Show resolved Hide resolved
@fivetran-joemarkiewicz
Copy link
Contributor

@fivetran-jamie One last item. For posterity, would you be able to update the description of the PR. Just to highlight the other PRs that were merged into here.

fivetran-jamie and others added 17 commits January 31, 2023 09:31
Co-authored-by: Joe Markiewicz <74217849+fivetran-joemarkiewicz@users.noreply.github.com>
Co-authored-by: Joe Markiewicz <74217849+fivetran-joemarkiewicz@users.noreply.github.com>
Co-authored-by: Joe Markiewicz <74217849+fivetran-joemarkiewicz@users.noreply.github.com>
Co-authored-by: Joe Markiewicz <74217849+fivetran-joemarkiewicz@users.noreply.github.com>
Co-authored-by: Joe Markiewicz <74217849+fivetran-joemarkiewicz@users.noreply.github.com>
Co-authored-by: Joe Markiewicz <74217849+fivetran-joemarkiewicz@users.noreply.github.com>
Co-authored-by: Joe Markiewicz <74217849+fivetran-joemarkiewicz@users.noreply.github.com>
Co-authored-by: Joe Markiewicz <74217849+fivetran-joemarkiewicz@users.noreply.github.com>
Co-authored-by: Joe Markiewicz <74217849+fivetran-joemarkiewicz@users.noreply.github.com>
Co-authored-by: Joe Markiewicz <74217849+fivetran-joemarkiewicz@users.noreply.github.com>
Co-authored-by: Joe Markiewicz <74217849+fivetran-joemarkiewicz@users.noreply.github.com>
Co-authored-by: Joe Markiewicz <74217849+fivetran-joemarkiewicz@users.noreply.github.com>
Co-authored-by: Joe Markiewicz <74217849+fivetran-joemarkiewicz@users.noreply.github.com>
@fivetran-jamie fivetran-jamie merged commit 3ee6cc2 into main Jan 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants