revert _timestamp field name changes #42
Conversation
There was a problem hiding this comment.
@fivetran-jamie looks good, just some clarifying questions!
| @@ -41,12 +41,6 @@ | |||
| - Dependencies on `fivetran/fivetran_utils` have been upgraded, previously `[">=0.3.0", "<0.4.0"]` now `[">=0.4.0", "<0.5.0"]`. | |||
|
|
|||
| [PR #40](https://github.com/fivetran/dbt_shopify_source/pull/40) includes the following breaking changes: | |||
| - In the following tables, `*_timestamp` columns have been renamed to `*_at` for consistency: | |||
There was a problem hiding this comment.
Was a bit confused looking at PR #40, I didn't see the timestamp renaming? Was this merged in an earlier PR?
There was a problem hiding this comment.
yeah so we currently rename these fields in main - https://github.com/fivetran/dbt_shopify_source/blob/main/macros/staging_columns.sql#L5
in my previous PR, i removed the alias when i moved around the staging column macros
| - `stg_shopify__order` | ||
| - `stg_shopify__product_variant` | ||
| - `stg_shopify__product` | ||
| - `stg_shopify__transaction` |
There was a problem hiding this comment.
Was there a reason we just changed these tables to the timestamp format? I see some others still in the _at format. https://github.com/fivetran/dbt_shopify_source/blob/feature/package-revamp/models/stg_shopify__refund.sql
There was a problem hiding this comment.
not that i can tell, it seems like a stylistic choice Dylan made for the most pertinent timestamp columns
Are you a current Fivetran customer?
fivetran made PR
What change(s) does this PR introduce?
*_atto*_timestampand decided to not do this for consistency. however, this introduced quite a few downstream errors in the transform package (and shopify holistic reporting). i don't think it's worth it to make this change, so this PR reverts what i didDid you update the CHANGELOG?
Does this PR introduce a breaking change?
this AVOIDS a breaking change
Did you update the dbt_project.yml files with the version upgrade (please leverage standard semantic versioning)? (In both your main project and integration_tests)
Is this PR in response to a previously created Bug or Feature Request
How did you test the PR changes?
Select which warehouse(s) were used to test the PR
Provide an emoji that best describes your current mood
🐖
Feedback
We are so excited you decided to contribute to the Fivetran community dbt package! We continue to work to improve the packages and would greatly appreciate your feedback on our existing dbt packages or what you'd like to see next.