-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update field selection, etc #40
Update field selection, etc #40
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Jamie! Just had some minor comments
@@ -1,6 +1,15 @@ | |||
--To disable this model, set the shopify__using_refund variable within your dbt_project.yml file to False. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you mind explaining why this model is different than the rest?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if i remember correctly, a request to do this came from a customer to @fivetran-joemarkiewicz ... joe would you mind elaborating here if i didn't make that up lol
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The refund tables are only synced once a refund is provided. Therefore, a customer could go months without refunding anything and never use that table. However, the second a refund is provided this table will be synced.
The experience from the customer was that it was difficult to maintain when refunds started. This is not a "I don't use this feature" as it is always used, but will only start syncing once a refund is provided. Customers shouldn't have to worry about managing their dbt project once refunds are processed. Therefore we took the approach of having this refund table be one that syncs as empty if it is not populated, then seamlessly switches to the source table once it exists.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Are you a current Fivetran customer?
Fivetran made PR
What change(s) does this PR introduce?
_at
fields to_timestamp
(so we don't change their names. did this for consistency across the package)Did you update the CHANGELOG?
NOT ENTIRELY i just noted the models i switched the timestamp column names in bc it was a low lift
Does this PR introduce a breaking change?
its base branch is a breaking change
Did you update the dbt_project.yml files with the version upgrade (please leverage standard semantic versioning)? (In both your main project and integration_tests)
NA
Is this PR in response to a previously created Bug or Feature Request
How did you test the PR changes?
Select which warehouse(s) were used to test the PR
Provide an emoji that best describes your current mood
⛈️
Feedback
We are so excited you decided to contribute to the Fivetran community dbt package! We continue to work to improve the packages and would greatly appreciate your feedback on our existing dbt packages or what you'd like to see next.