Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/metafields #49

Merged
merged 2 commits into from
Jan 24, 2023

Conversation

fivetran-joemarkiewicz
Copy link
Contributor

Are you a current Fivetran customer?

Fivetran created PR

What change(s) does this PR introduce?

This PR adds two additional fields to the stg_shopify__metafield model. These fields are crucial for downstream metafield mapping purposes.

Did you update the CHANGELOG?

  • Yes
    The addition of the metafield model has already been included in the CHANGELOG. Therefore, there was no need to mark this entry.

Does this PR introduce a breaking change?

  • Yes (please provide breaking change details below.)
  • No (please provide an explanation as to how the change is non-breaking below.)

Did you update the dbt_project.yml files with the version upgrade (please leverage standard semantic versioning)? (In both your main project and integration_tests)

  • Yes

Is this PR in response to a previously created Bug or Feature Request

  • Yes, Issue/Feature [link bug/feature number here]
  • No

How did you test the PR changes?

  • Buildkite
  • Local (please provide additional testing details below)

Select which warehouse(s) were used to test the PR

  • BigQuery
  • Redshift
  • Snowflake
  • Postgres
  • Databricks
  • Other (provide details below)

Provide an emoji that best describes your current mood

🤘

Feedback

We are so excited you decided to contribute to the Fivetran community dbt package! We continue to work to improve the packages and would greatly appreciate your feedback on our existing dbt packages or what you'd like to see next.

@fivetran-joemarkiewicz fivetran-joemarkiewicz changed the base branch from main to feature/package-revamp January 23, 2023 21:40
@fivetran-joemarkiewicz fivetran-joemarkiewicz marked this pull request as ready for review January 23, 2023 22:12
Copy link
Contributor

@fivetran-jamie fivetran-jamie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good -- just a question around is_most_recent_record since it doesn't appear to ever be false (and we don't use it downstream?)

models/stg_shopify__metafield.sql Show resolved Hide resolved
@fivetran-joemarkiewicz fivetran-joemarkiewicz merged commit 7945295 into feature/package-revamp Jan 24, 2023
@fivetran-joemarkiewicz fivetran-joemarkiewicz deleted the feature/metafields branch January 24, 2023 22:56
@fivetran-jamie fivetran-jamie mentioned this pull request Jan 31, 2023
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants