Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/revamp -- add new tables and fields #39

Merged
merged 23 commits into from
Dec 14, 2022

Conversation

fivetran-jamie
Copy link
Contributor

@fivetran-jamie fivetran-jamie commented Dec 8, 2022

Are you a current Fivetran customer?

fivetran made PR

What change(s) does this PR introduce?

  • adds new sources and documents them
  • adds new staging tables and documents + tests them
  • adds new fields to existing models. documentation of these new fields will happen in a later PR
  • moved column macros to individual column macros (and delete the staging_columns.sql file). I will move the aliasing from the column macros to the model files in my next PR
  • new seed data

@fivetran-jamie fivetran-jamie self-assigned this Dec 8, 2022
Copy link
Contributor

@fivetran-reneeli fivetran-reneeli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @fivetran-jamie wow lots of new tables! It looks good, just had some minor things:

  • cast timestamps fields in staging models with dbt.type_timestamp (I recall this being included in our standardization updates so may as well follow it here)
  • maybe update 'index' in the respective staging models to specify which model it's from? This is more if you think this field gets used downstream at some point, and there's so many models that the same field (customer_tag, abandoned_checkout_discount_code, order_shipping_tax_line, order_tag, product_tag)
  • I noticed you added the union data feature to the tmp models, don't forget to add the source relation macro and column to staging models!

@fivetran-jamie
Copy link
Contributor Author

ah yeah index won't really get used so i think we're good not renaming it. otherwise, added the source relation stuff and the timestamp casts! will also make sure to add the timestamp casts to the other models in my other PR

Copy link
Contributor

@fivetran-reneeli fivetran-reneeli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The timestamp updates and union data macro addition look good to go 👍

@fivetran-jamie fivetran-jamie merged commit cd307dc into feature/package-revamp Dec 14, 2022
@fivetran-jamie fivetran-jamie deleted the feature/revamp/new-tables branch December 14, 2022 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants