Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

transform work, some documentation #47

Merged

Conversation

fivetran-jamie
Copy link
Contributor

@fivetran-jamie fivetran-jamie commented Jan 10, 2023

Are you a current Fivetran customer?

fivetran made PR

What change(s) does this PR introduce?

  • light and INCOMPLETE docs work. This is definitely in progress, and the docs work here is just stuff i've been able to do in my free time
  • fixes up the new fields in customer (re [Schema Change] <Shopify API Update 2022> #46)
  • identifier vars for new tables
  • added a new table (abandoned_checkout_shipping_line)
  • consistent casing of things we join on (ie email and discount code)

Did you update the CHANGELOG?

  • Yes

a little but this will be completed in a later PR

Is this PR in response to a previously created Bug or Feature Request

How did you test the PR changes?

  • Buildkite
  • Local (please provide additional testing details below)

Select which warehouse(s) were used to test the PR

  • BigQuery
  • Redshift
  • Snowflake
  • Postgres
  • Databricks
  • Other (provide details below)

Provide an emoji that best describes your current mood

💃

Feedback

We are so excited you decided to contribute to the Fivetran community dbt package! We continue to work to improve the packages and would greatly appreciate your feedback on our existing dbt packages or what you'd like to see next.

@fivetran-jamie
Copy link
Contributor Author

this doesn't need to be merged ASAP, just want eyes on it/aware of these changes as we work more on the transform package

Copy link
Contributor

@fivetran-joemarkiewicz fivetran-joemarkiewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My only comment is to make the new tests you added for the accepted values to be warnings instead of hard failures. Other than than, this looks great @fivetran-jamie!!

@fivetran-jamie fivetran-jamie merged commit f9b43f7 into feature/package-revamp Jan 11, 2023
@fivetran-jamie fivetran-jamie mentioned this pull request Jan 31, 2023
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants