-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
transform work, some documentation #47
transform work, some documentation #47
Conversation
this doesn't need to be merged ASAP, just want eyes on it/aware of these changes as we work more on the transform package |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My only comment is to make the new tests you added for the accepted values to be warnings instead of hard failures. Other than than, this looks great @fivetran-jamie!!
Are you a current Fivetran customer?
fivetran made PR
What change(s) does this PR introduce?
abandoned_checkout_shipping_line
)Did you update the CHANGELOG?
a little but this will be completed in a later PR
Is this PR in response to a previously created Bug or Feature Request
How did you test the PR changes?
Select which warehouse(s) were used to test the PR
Provide an emoji that best describes your current mood
💃
Feedback
We are so excited you decided to contribute to the Fivetran community dbt package! We continue to work to improve the packages and would greatly appreciate your feedback on our existing dbt packages or what you'd like to see next.