package standardization updates + postgres compat #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…/dbt_shopify_source into feature/package_updates
Co-authored-by: Joe Markiewicz <74217849+fivetran-joemarkiewicz@users.noreply.github.com>
Co-authored-by: Joe Markiewicz <74217849+fivetran-joemarkiewicz@users.noreply.github.com>
Co-authored-by: Joe Markiewicz <74217849+fivetran-joemarkiewicz@users.noreply.github.com>
Feature/package updates
fivetran-jamie
commented
Dec 6, 2022
| @@ -1,6 +1,6 @@ | |||
| {{ | |||
| fivetran_utils.union_data( | |||
| table_identifier='order', | |||
| table_identifier='order', | |||
There was a problem hiding this comment.
@fivetran-reneeli actually does this need to be shopify_order_identifier ?
There was a problem hiding this comment.
Oh I think you're right. I'll make the changes to my stripe package too now. Thanks for noticing
There was a problem hiding this comment.
sweet will also update
There was a problem hiding this comment.
wait wait i'm wrong!!!
There was a problem hiding this comment.
it should be the name of the source table node (which we ourselves have defined), not the source table node's identifier
| @@ -1,6 +1,6 @@ | |||
| {{ | |||
| fivetran_utils.union_data( | |||
| table_identifier='order', | |||
| table_identifier='order', | |||
There was a problem hiding this comment.
Oh I think you're right. I'll make the changes to my stripe package too now. Thanks for noticing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Are you a current Fivetran customer?
fivetran made PR
What change(s) does this PR introduce?
Did you update the CHANGELOG?
Does this PR introduce a breaking change?
Did you update the dbt_project.yml files with the version upgrade (please leverage standard semantic versioning)? (In both your main project and integration_tests)
Is this PR in response to a previously created Bug or Feature Request
How did you test the PR changes?
Select which warehouse(s) were used to test the PR
Provide an emoji that best describes your current mood
💃
Feedback
We are so excited you decided to contribute to the Fivetran community dbt package! We continue to work to improve the packages and would greatly appreciate your feedback on our existing dbt packages or what you'd like to see next.