[GCC 11] Fix error "this pointer is null" in PhysicsTools/FWLite

[iarspider]

Log file: https://cmssdt.cern.ch/SDT/cgi-bin/buildlogs/slc7_amd64_gcc11/CMSSW_12_1_X_2021-08-02-1100/PhysicsTools/FWLite
Error message:

/data/cmsbld/jenkins/workspace/build-any-ib/w/tmp/BUILDROOT/e3e3f354f3bbc00899d20eeb240b2272/opt/cmssw/slc7_amd64_gcc11/cms/cmssw/CMSSW_12_1_X_2021-08-02-1100/src/PhysicsTools/FWLite/interface/Scanner.h: In member function 'TH1* fwlite::Scanner<Collection>::draw(const char*, const char*, TString, const char*, const TH1*) [with Collection = std::vector<reco::Track>]':
  /data/cmsbld/jenkins/workspace/build-any-ib/w/tmp/BUILDROOT/e3e3f354f3bbc00899d20eeb240b2272/opt/cmssw/slc7_amd64_gcc11/cms/cmssw/CMSSW_12_1_X_2021-08-02-1100/src/PhysicsTools/FWLite/interface/Scanner.h:257:34: error: 'this' pointer is null [-Werror=nonnull]
   257 |         hist = (TH1 *)hist->Clone(hname);
      |                       ~~~~~~~~~~~^~~~~~~

PR description:

Method code now matches it's description

PR validation:

if this PR is a backport please specify the original PR and why you need to backport that PR:

Before submitting your pull requests, make sure you followed this checklist:

• verify that the PR is really intended for the chosen branch
• verify that changes follow CMS Naming, Coding, And Style Rules
• verify that the PR passes the basic test procedure suggested in the CMSSW PR instructions

[iarspider]

@cmsbuild please test for slc7_amd64_gcc11

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34769/24432

• This PR adds an extra 16KB to repository

[cmsbuild]

A new Pull Request was created by @iarspider for master.

It involves the following packages:

• PhysicsTools/FWLite (analysis)

@santocch can you please review it and eventually sign? Thanks.
@silviodonato, @dpiparo, @qliphy, @perrotta you are the release manager for this.

cms-bot commands are listed here

[cmsbuild]

-1

Failed Tests: Build
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0b545a/17517/summary.html
COMMIT: 4a02c25
CMSSW: CMSSW_12_1_X_2021-08-02-1100/slc7_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/34769/17517/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

• @smuzaffar [EventFilter] header cleanup to avoid private header usage #34739
• @jshlee GEM dataformat - fix classversion #34713
• @fwyzard Fix uploading EventSetup conditions from multiple CUDA streams #34725
• @bsunanda Run3-alca190 Modify the AlCaRecoProducer for HBHEMuon #34709
• @smuzaffar [Misc2][clang-tidy] make deleted function public #34691
• @smuzaffar [DD] Move public headers in to interface directory #34733
• @cms-tsg-storm HLT menu migration to CMSSW 12_0_0_pre5 template [12_1_X] #34740
• @yuanchao Remove unused headers of Calib- packages #34723
• @tklijnsma finecalo: No longer count reentries into the calorimeter as boundary crossings #34599
• @dmeuser TkDQM: Fill barycenter plots at EndRun #34720
• @zuoxunwu Online DQM: Add EMTF DQM plots on GEM information and their comparison to CSC inputs #34706
• @mseidel42 Allow HcalPulseContainment timePhase definition as in SIM #34572
• @dr-stringfellow Disable vertex smearing for workflows using CloseByParticleGun #34681
• @smuzaffar [Cond][clang-tidy] make deleted function public  #34682
• @smuzaffar [Sim][clang-tidy] make deleted function public #34683
• @smuzaffar [Sim] Move public headers on to interface directory #34734
• @bsunanda Run3-hcx306 Bug fix to get back the same hit energy distribution for HCAL #34738
• @francescobrivio Update DQM onlinebeammonitor #34719
• @smuzaffar [L1][clang-tidy] make deleted function public #34688
• @stahlleiton Adapted EcalRawToDigi and SiPixelRawToCluster GPU code for HIon #34664
• @smuzaffar [Fireworks][Clang-tidy] make deleted function public #34665

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0b545a/17517/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0b545a/17517/git-merge-result

Build

I found compilation error when building:

/cvmfs/cms-ib.cern.ch/nweek-02692/slc7_amd64_gcc11/external/gcc/11.1.0/bin/../lib/gcc/x86_64-unknown-linux-gnu/11.1.1/../../../../x86_64-unknown-linux-gnu/bin/ld: cannot find -lHeterogeneousCoreCUDACore
/cvmfs/cms-ib.cern.ch/nweek-02692/slc7_amd64_gcc11/external/gcc/11.1.0/bin/../lib/gcc/x86_64-unknown-linux-gnu/11.1.1/../../../../x86_64-unknown-linux-gnu/bin/ld: cannot find -lCUDADataFormatsHGCal
/cvmfs/cms-ib.cern.ch/nweek-02692/slc7_amd64_gcc11/external/gcc/11.1.0/bin/../lib/gcc/x86_64-unknown-linux-gnu/11.1.1/../../../../x86_64-unknown-linux-gnu/bin/ld: cannot find -lHeterogeneousCoreCUDAServices
/cvmfs/cms-ib.cern.ch/nweek-02692/slc7_amd64_gcc11/external/gcc/11.1.0/bin/../lib/gcc/x86_64-unknown-linux-gnu/11.1.1/../../../../x86_64-unknown-linux-gnu/bin/ld: cannot find -lCUDADataFormatsCommon
/cvmfs/cms-ib.cern.ch/nweek-02692/slc7_amd64_gcc11/external/gcc/11.1.0/bin/../lib/gcc/x86_64-unknown-linux-gnu/11.1.1/../../../../x86_64-unknown-linux-gnu/bin/ld: cannot find -lHeterogeneousCoreCUDAUtilities
collect2: error: ld returned 1 exit status
gmake: *** [tmp/slc7_amd64_gcc11/src/CondFormats/HGCalObjects/src/CondFormatsHGCalObjects/libCondFormatsHGCalObjects.so] Error 1
Leaving library rule at CondFormats/HGCalObjects
>> Leaving Package CondFormats/HGCalObjects
>> Package CondFormats/HGCalObjects built
>> Entering Package DQM/SiPixelPhase1Summary


[smuzaffar]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0b545a/17536/summary.html
COMMIT: 4a02c25
CMSSW: CMSSW_12_1_X_2021-08-03-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/34769/17536/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

• @cms-tsg-storm HLT menu migration to CMSSW 12_0_0_pre5 template [12_1_X] #34740
• @zuoxunwu Online DQM: Add EMTF DQM plots on GEM information and their comparison to CSC inputs #34706
• @mseidel42 Allow HcalPulseContainment timePhase definition as in SIM #34572
• @smuzaffar [EventFilter] header cleanup to avoid private header usage #34739

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0b545a/17536/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0b545a/17536/git-merge-result

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 39
• DQMHistoTests: Total histograms compared: 2998558
• DQMHistoTests: Total failures: 5
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2998531
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 13814.586 KiB( 38 files compared)
• DQMHistoSizes: changed ( 10024.0,... ): 767.477 KiB L1T/L1TStage2EMTF
• Checked 165 log files, 37 edm output root files, 39 DQM output files
• TriggerResults: found differences in 4 / 38 workflows

[perrotta]

+1

• @cms-sw/analysis-l2 the fix is logical

[perrotta]

merge

[santocch]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged.