-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run3-hcx306 Bug fix to get back the same hit energy distribution for HCAL #34738
Conversation
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34738/24388
|
A new Pull Request was created by @bsunanda (Sunanda Banerjee) for master. It involves the following packages:
@cmsbuild, @civanch, @mdhildreth can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@cmsbuild Please test |
type bugfix |
@bsunanda thank you for the fix. |
Pion gun "CaloScan" test of |
@bsunanda , thanks for this critical fix and @abdoulline , thank for the prompt analysis. This PR should be backported to 12_0_X. 12_0_0_pre5 is broken and this fix recover HCAL hits. |
-1 Failed Tests: RelVals-INPUT RelVals-INPUT
Expand to see more relval errors ...
Comparison SummarySummary:
|
+1 @silviodonato, @dpiparo, @qliphy, @perrotta , this fix recover 12_0_0_pre5 HCAL problem. |
This pull request is fully signed and it will be integrated in one of the next master IBs (but tests are reportedly failing). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy, @perrotta (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
@bsunanda (or anyone else) please prepare a backport for 12_0_X |
merge |
Run3-hcx306X Bug fix (backport #34738) to HCAL SD class
PR description:
Bug fix to get back the same hit energy distribution for HCAL
PR validation:
Tested using the script inside SimG4CMS/Calo/test/python
if this PR is a backport please specify the original PR and why you need to backport that PR:
Nothing to be back ported