[GCC 11] Fix error "this pointer is null" in DQM/SiStripCommissioningDbClients

[iarspider]

Log file: https://cmssdt.cern.ch/SDT/cgi-bin/buildlogs/slc7_amd64_gcc11/CMSSW_12_1_X_2021-07-30-0900/DQM/SiStripCommissioningDbClients
Error message:

/data/cmsbld/jenkins/workspace/build-any-ib/w/tmp/BUILDROOT/3f7c5ca595fd8634b26b919adc27f210/opt/cmssw/slc7_amd64_gcc11/cms/cmssw/CMSSW_12_1_X_2021-07-30-0900/src/DQM/SiStripCommissioningDbClients/src/FastFedCablingHistosUsingDb.cc: In member function 'void FastFedCablingHistosUsingDb::connections(SiStripConfigDb::DeviceDescriptionsRange, SiStripConfigDb::DcuDetIdsRange)':
  /data/cmsbld/jenkins/workspace/build-any-ib/w/tmp/BUILDROOT/3f7c5ca595fd8634b26b919adc27f210/opt/cmssw/slc7_amd64_gcc11/cms/cmssw/CMSSW_12_1_X_2021-07-30-0900/src/DQM/SiStripCommissioningDbClients/src/FastFedCablingHistosUsingDb.cc:476:49: error: 'this' pointer is null [-Werror=nonnull]
   476 |     uint16_t npairs = idet->second->getApvNumber() / 2;
      |                       ~~~~~~~~~~~~~~~~~~~~~~~~~~^~
In file included from /data/cmsbld/jenkins/workspace/build-any-ib/w/slc7_amd64_gcc11/external/tkonlinesw/4.2.0-1_gcc7-fc776fdba2d2dc7e5bcd24170ad0d08e/include/TkDcuConversionFactors.h:30,
                 from /data/cmsbld/jenkins/workspace/build-any-ib/w/slc7_amd64_gcc11/external/tkonlinesw/4.2.0-1_gcc7-fc776fdba2d2dc7e5bcd24170ad0d08e/include/deviceType.h:30,
                 from /data/cmsbld/jenkins/workspace/build-any-ib/w/slc7_amd64_gcc11/external/tkonlinesw/4.2.0-1_gcc7-fc776fdba2d2dc7e5bcd24170ad0d08e/include/FecFactory.h:33,
                 from /data/cmsbld/jenkins/workspace/build-any-ib/w/slc7_amd64_gcc11/external/tkonlinesw/4.2.0-1_gcc7-fc776fdba2d2dc7e5bcd24170ad0d08e/include/DeviceFactory.h:26,
                 from /data/cmsbld/jenkins/workspace/build-any-ib/w/tmp/BUILDROOT/3f7c5ca595fd8634b26b919adc27f210/opt/cmssw/slc7_amd64_gcc11/cms/cmssw/CMSSW_12_1_X_2021-07-30-0900/src/OnlineDB/SiStripConfigDb/interface/SiStripConfigDb.h:17,
                 from /data/cmsbld/jenkins/workspace/build-any-ib/w/tmp/BUILDROOT/3f7c5ca595fd8634b26b919adc27f210/opt/cmssw/slc7_amd64_gcc11/cms/cmssw/CMSSW_12_1_X_2021-07-30-0900/src/DQM/SiStripCommissioningDbClients/interface/CommissioningHistosUsingDb.h:8,
                 from /data/cmsbld/jenkins/workspace/build-any-ib/w/tmp/BUILDROOT/3f7c5ca595fd8634b26b919adc27f210/opt/cmssw/slc7_amd64_gcc11/cms/cmssw/CMSSW_12_1_X_2021-07-30-0900/src/DQM/SiStripCommissioningDbClients/interface/FastFedCablingHistosUsingDb.h:5,
                 from /data/cmsbld/jenkins/workspace/build-any-ib/w/tmp/BUILDROOT/3f7c5ca595fd8634b26b919adc27f210/opt/cmssw/slc7_amd64_gcc11/cms/cmssw/CMSSW_12_1_X_2021-07-30-0900/src/DQM/SiStripCommissioningDbClients/src/FastFedCablingHistosUsingDb.cc:2:
/data/cmsbld/jenkins/workspace/build-any-ib/w/slc7_amd64_gcc11/external/tkonlinesw/4.2.0-1_gcc7-fc776fdba2d2dc7e5bcd24170ad0d08e/include/TkDcuInfo.h:126:13: note: in a call to non-static member function 'tscType32 TkDcuInfo::getApvNumber()'
  126 |   tscType32 getApvNumber( ) ;
      |             ^~~~~~~~~~~~

PR description:

PR validation:

if this PR is a backport please specify the original PR and why you need to backport that PR:

Before submitting your pull requests, make sure you followed this checklist:

• verify that the PR is really intended for the chosen branch
• verify that changes follow CMS Naming, Coding, And Style Rules
• verify that the PR passes the basic test procedure suggested in the CMSSW PR instructions

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34758/24423

• This PR adds an extra 16KB to repository

[cmsbuild]

A new Pull Request was created by @iarspider for master.

It involves the following packages:

• DQM/SiStripCommissioningDbClients (dqm)

@andrius-k, @kmaeshima, @ErnestaP, @ahmad3213, @cmsbuild, @jfernan2, @rvenditti can you please review it and eventually sign? Thanks.
@erikbutz, @threus this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy, @perrotta you are the release manager for this.

cms-bot commands are listed here

[jfernan2]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-382a4c/17505/summary.html
COMMIT: 87f163b
CMSSW: CMSSW_12_1_X_2021-08-03-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/34758/17505/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

• @smuzaffar [EventFilter] header cleanup to avoid private header usage #34739

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-382a4c/17505/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-382a4c/17505/git-merge-result

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 39
• DQMHistoTests: Total histograms compared: 2998564
• DQMHistoTests: Total failures: 6
• DQMHistoTests: Total nulls: 1
• DQMHistoTests: Total successes: 2998535
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: -0.004 KiB( 38 files compared)
• DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
• Checked 165 log files, 37 edm output root files, 39 DQM output files
• TriggerResults: no differences found

[iarspider]

@cmsbuild please test for slc7_amd64_gcc11

[cmsbuild]

-1

Failed Tests: Build
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-382a4c/17513/summary.html
COMMIT: 87f163b
CMSSW: CMSSW_12_1_X_2021-08-02-1100/slc7_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/34758/17513/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

• @smuzaffar [EventFilter] header cleanup to avoid private header usage #34739
• @jshlee GEM dataformat - fix classversion #34713
• @fwyzard Fix uploading EventSetup conditions from multiple CUDA streams #34725
• @bsunanda Run3-alca190 Modify the AlCaRecoProducer for HBHEMuon #34709
• @smuzaffar [Misc2][clang-tidy] make deleted function public #34691
• @smuzaffar [DD] Move public headers in to interface directory #34733
• @yuanchao Remove unused headers of Calib- packages #34723
• @tklijnsma finecalo: No longer count reentries into the calorimeter as boundary crossings #34599
• @dmeuser TkDQM: Fill barycenter plots at EndRun #34720
• @bsunanda Run3-hcx306 Bug fix to get back the same hit energy distribution for HCAL #34738
• @dr-stringfellow Disable vertex smearing for workflows using CloseByParticleGun #34681
• @smuzaffar [Cond][clang-tidy] make deleted function public  #34682
• @smuzaffar [Sim][clang-tidy] make deleted function public #34683
• @smuzaffar [Sim] Move public headers on to interface directory #34734
• @francescobrivio Update DQM onlinebeammonitor #34719
• @smuzaffar [L1][clang-tidy] make deleted function public #34688
• @stahlleiton Adapted EcalRawToDigi and SiPixelRawToCluster GPU code for HIon #34664
• @smuzaffar [Fireworks][Clang-tidy] make deleted function public #34665

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-382a4c/17513/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-382a4c/17513/git-merge-result

Build

I found compilation error when building:

/cvmfs/cms-ib.cern.ch/nweek-02692/slc7_amd64_gcc11/external/gcc/11.1.0/bin/../lib/gcc/x86_64-unknown-linux-gnu/11.1.1/../../../../x86_64-unknown-linux-gnu/bin/ld: cannot find -lHeterogeneousCoreCUDACore
/cvmfs/cms-ib.cern.ch/nweek-02692/slc7_amd64_gcc11/external/gcc/11.1.0/bin/../lib/gcc/x86_64-unknown-linux-gnu/11.1.1/../../../../x86_64-unknown-linux-gnu/bin/ld: cannot find -lCUDADataFormatsHGCal
/cvmfs/cms-ib.cern.ch/nweek-02692/slc7_amd64_gcc11/external/gcc/11.1.0/bin/../lib/gcc/x86_64-unknown-linux-gnu/11.1.1/../../../../x86_64-unknown-linux-gnu/bin/ld: cannot find -lHeterogeneousCoreCUDAServices
/cvmfs/cms-ib.cern.ch/nweek-02692/slc7_amd64_gcc11/external/gcc/11.1.0/bin/../lib/gcc/x86_64-unknown-linux-gnu/11.1.1/../../../../x86_64-unknown-linux-gnu/bin/ld: cannot find -lCUDADataFormatsCommon
/cvmfs/cms-ib.cern.ch/nweek-02692/slc7_amd64_gcc11/external/gcc/11.1.0/bin/../lib/gcc/x86_64-unknown-linux-gnu/11.1.1/../../../../x86_64-unknown-linux-gnu/bin/ld: cannot find -lHeterogeneousCoreCUDAUtilities
collect2: error: ld returned 1 exit status
gmake: *** [tmp/slc7_amd64_gcc11/src/CondFormats/HGCalObjects/src/CondFormatsHGCalObjects/libCondFormatsHGCalObjects.so] Error 1
Leaving library rule at CondFormats/HGCalObjects
>> Leaving Package CondFormats/HGCalObjects
>> Package CondFormats/HGCalObjects built
>> Entering Package DQM/SiPixelPhase1Summary


[iarspider]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-382a4c/17546/summary.html
COMMIT: 87f163b
CMSSW: CMSSW_12_1_X_2021-08-04-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/34758/17546/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 2 differences found in the comparisons
• DQMHistoTests: Total files compared: 39
• DQMHistoTests: Total histograms compared: 2998564
• DQMHistoTests: Total failures: 7
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2998535
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 38 files compared)
• Checked 165 log files, 37 edm output root files, 39 DQM output files
• TriggerResults: no differences found

[qliphy]

kindly ping @cms-sw/dqm-l2

[jfernan2]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1

• Simple fix

[perrotta]

@iarspider @jfernan2 : does this fix need to be backported to 12_0_X? Is FastFedCablingHistosUsingDb ever used?