Disable vertex smearing for workflows using CloseByParticleGun #34681
Conversation
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34681/24304
|
|
A new Pull Request was created by @dr-stringfellow for master. It involves the following packages:
@perrotta, @civanch, @jordan-martins, @chayanit, @bbilin, @wajidalikhan, @kpedro88, @cmsbuild, @silviodonato, @srimanob, @mdhildreth, @kskovpen, @qliphy, @fabiocos, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
Please test |
| if 'HLBeamSpot' in step: | ||
| if '14TeV' in frag: | ||
| step = 'GenSimHLBeamSpot14' | ||
| if 'CloseByParticle' in frag: |
There was a problem hiding this comment.
Do you want to adjust only
https://github.com/cms-sw/cmssw/blob/master/Configuration/PyReleaseValidation/python/upgradeWorkflowComponents.py#L1386
or also
https://github.com/cms-sw/cmssw/blob/master/Configuration/PyReleaseValidation/python/upgradeWorkflowComponents.py#L1387-L1394
(as they are also clsebyparticle gun for HGCAL, #27631)
There was a problem hiding this comment.
Yeah true, better to pattern match also CE_H and CE_E. Can I just update the code in my repository and it will redo checks?
There was a problem hiding this comment.
I will re-trigger the code testing. Feel free to push an updated one.
There was a problem hiding this comment.
Thanks! Pushed!
|
Please abort |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34681/24365
|
|
Pull request #34681 was updated. @perrotta, @civanch, @jordan-martins, @chayanit, @bbilin, @wajidalikhan, @kpedro88, @AdrianoDee, @srimanob, @silviodonato, @mdhildreth, @kskovpen, @qliphy, @fabiocos, @davidlange6 can you please check and sign again. |
|
-1 Failed Tests: RelVals-INPUT RelVals-INPUT
Expand to see more relval errors ...
Comparison SummarySummary:
|
|
+1 |
|
+operations |
|
+Upgrade This PR is to correct BS smearing in closebyparticle gun used for HGCAL relvals. |
|
@cms-sw/pdmv-l2 you already signed this PR before last commit, whose last commit only renamed the step by removing "14TeV" from it. I assume that you are still ok with this PR, just complain in case you changed your mind. |
|
+1 |
|
merge |
PR description:
This PR disables any GEN->SIM vertex smearing for upgrade workflows using the CloseByParticleGun. HLLHC-like vertex smearing, as was the default so far for such workflows, defies the purpose of the CloseByParticleGun. In practical terms: if we want to position the particle gun right in front of the detector (HGCAL), we do not want to have a vertex smearing applied that would move the position of the simulated vertex into the detector, as this would bias our studies and mess with truth definitions etc. If a spread in Z position of the vertex is desired, this can be handled through the config of the CloseByParticleGun.
Hence, switch to a Gaussian Vertex smearing with width_x/y/z = 0 for all workflows using the CloseByParticleGun.
PR validation:
edmConfigDump on step1.py for an upgrade workflow that would previously have the smearing applied, like:
runTheMatrix.py -w upgrade -l 34693.0 -t 10 -j 0 --command '-n 10'shows that the desired configuration was fetched.Verified that GEN vertex and SIM vertex positions are identical for 10 events.