Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GCC 11] Fix error "array subscript outside array bounds" #34757

Merged
merged 1 commit into from
Aug 10, 2021
Merged

[GCC 11] Fix error "array subscript outside array bounds" #34757

merged 1 commit into from
Aug 10, 2021

Conversation

iarspider
Copy link
Contributor

Log file: https://cmssdt.cern.ch/SDT/cgi-bin/buildlogs/slc7_amd64_gcc11/CMSSW_12_1_X_2021-07-30-0900/CondCore/EcalPlugins
Error message:

/data/cmsbld/jenkins/workspace/build-any-ib/w/tmp/BUILDROOT/3f7c5ca595fd8634b26b919adc27f210/opt/cmssw/slc7_amd64_gcc11/cms/cmssw/CMSSW_12_1_X_2021-07-30-0900/src/CondCore/EcalPlugins/plugins/EcalFloatCondObjectContainer_PayloadInspector.cc: In member function 'virtual bool {anonymous}::EcalFloatCondObjectContainerPlot::fill(const std::vector<std::tuple<long long unsigned int, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > > >&)':
  /data/cmsbld/jenkins/workspace/build-any-ib/w/tmp/BUILDROOT/3f7c5ca595fd8634b26b919adc27f210/opt/cmssw/slc7_amd64_gcc11/cms/cmssw/CMSSW_12_1_X_2021-07-30-0900/src/CondCore/EcalPlugins/plugins/EcalFloatCondObjectContainer_PayloadInspector.cc:120:17: error: array subscript 1 is outside array bounds of 'TPad* [1]' [-Werror=array-bounds]
   120 |       pad[1]->cd();
      |       ~~~~~~~~~~^~
/data/cmsbld/jenkins/workspace/build-any-ib/w/tmp/BUILDROOT/3f7c5ca595fd8634b26b919adc27f210/opt/cmssw/slc7_amd64_gcc11/cms/cmssw/CMSSW_12_1_X_2021-07-30-0900/src/CondCore/EcalPlugins/plugins/EcalFloatCondObjectContainer_PayloadInspector.cc:112:28: note: referencing an object of size 8 allocated by 'void* operator new(std::size_t)'
  112 |       TPad** pad = new TPad*;
      |                            ^
  /data/cmsbld/jenkins/workspace/build-any-ib/w/tmp/BUILDROOT/3f7c5ca595fd8634b26b919adc27f210/opt/cmssw/slc7_amd64_gcc11/cms/cmssw/CMSSW_12_1_X_2021-07-30-0900/src/CondCore/EcalPlugins/plugins/EcalFloatCondObjectContainer_PayloadInspector.cc:122:17: error: array subscript 2 is outside array bounds of 'TPad* [1]' [-Werror=array-bounds]
   122 |       pad[2]->cd();
      |       ~~~~~~~~~~^~
/data/cmsbld/jenkins/workspace/build-any-ib/w/tmp/BUILDROOT/3f7c5ca595fd8634b26b919adc27f210/opt/cmssw/slc7_amd64_gcc11/cms/cmssw/CMSSW_12_1_X_2021-07-30-0900/src/CondCore/EcalPlugins/plugins/EcalFloatCondObjectContainer_PayloadInspector.cc:112:28: note: referencing an object of size 8 allocated by 'void* operator new(std::size_t)'
  112 |       TPad** pad = new TPad*;
      |                            ^
/data/cmsbld/jenkins/workspace/build-any-ib/w/tmp/BUILDROOT/3f7c5ca595fd8634b26b919adc27f210/opt/cmssw/slc7_amd64_gcc11/cms/cmssw/CMSSW_12_1_X_2021-07-30-0900/src/CondCore/EcalPlugins/plugins/EcalFloatCondObjectContainer_PayloadInspector.cc: In member function 'bool {anonymous}::EcalFloatCondObjectContainerDiffBase<nIOVs, ntags>::fill() [with cond::payloadInspector::IOVMultiplicity nIOVs = cond::payloadInspector::SINGLE_IOV; int ntags = 1]':
  /data/cmsbld/jenkins/workspace/build-any-ib/w/tmp/BUILDROOT/3f7c5ca595fd8634b26b919adc27f210/opt/cmssw/slc7_amd64_gcc11/cms/cmssw/CMSSW_12_1_X_2021-07-30-0900/src/CondCore/EcalPlugins/plugins/EcalFloatCondObjectContainer_PayloadInspector.cc:273:17: error: array subscript 1 is outside array bounds of 'TPad* [1]' [-Werror=array-bounds]
   273 |       pad[1]->cd();
      |       ~~~~~~~~~~^~
/data/cmsbld/jenkins/workspace/build-any-ib/w/tmp/BUILDROOT/3f7c5ca595fd8634b26b919adc27f210/opt/cmssw/slc7_amd64_gcc11/cms/cmssw/CMSSW_12_1_X_2021-07-30-0900/src/CondCore/EcalPlugins/plugins/EcalFloatCondObjectContainer_PayloadInspector.cc:265:20: note: referencing an object of size 8 allocated by 'void* operator new(std::size_t)'
  265 |       TPad** pad = new TPad*;
      |                    ^~~~~~~~~
  /data/cmsbld/jenkins/workspace/build-any-ib/w/tmp/BUILDROOT/3f7c5ca595fd8634b26b919adc27f210/opt/cmssw/slc7_amd64_gcc11/cms/cmssw/CMSSW_12_1_X_2021-07-30-0900/src/CondCore/EcalPlugins/plugins/EcalFloatCondObjectContainer_PayloadInspector.cc:275:17: error: array subscript 2 is outside array bounds of 'TPad* [1]' [-Werror=array-bounds]
   275 |       pad[2]->cd();
      |       ~~~~~~~~~~^~
/data/cmsbld/jenkins/workspace/build-any-ib/w/tmp/BUILDROOT/3f7c5ca595fd8634b26b919adc27f210/opt/cmssw/slc7_amd64_gcc11/cms/cmssw/CMSSW_12_1_X_2021-07-30-0900/src/CondCore/EcalPlugins/plugins/EcalFloatCondObjectContainer_PayloadInspector.cc:265:20: note: referencing an object of size 8 allocated by 'void* operator new(std::size_t)'
  265 |       TPad** pad = new TPad*;
      |                    ^~~~~~~~~
/data/cmsbld/jenkins/workspace/build-any-ib/w/tmp/BUILDROOT/3f7c5ca595fd8634b26b919adc27f210/opt/cmssw/slc7_amd64_gcc11/cms/cmssw/CMSSW_12_1_X_2021-07-30-0900/src/CondCore/EcalPlugins/plugins/EcalFloatCondObjectContainer_PayloadInspector.cc: In member function 'bool {anonymous}::EcalFloatCondObjectContainerDiffBase<nIOVs, ntags>::fill() [with cond::payloadInspector::IOVMultiplicity nIOVs = cond::payloadInspector::SINGLE_IOV; int ntags = 2]':
  /data/cmsbld/jenkins/workspace/build-any-ib/w/tmp/BUILDROOT/3f7c5ca595fd8634b26b919adc27f210/opt/cmssw/slc7_amd64_gcc11/cms/cmssw/CMSSW_12_1_X_2021-07-30-0900/src/CondCore/EcalPlugins/plugins/EcalFloatCondObjectContainer_PayloadInspector.cc:273:17: error: array subscript 1 is outside array bounds of 'TPad* [1]' [-Werror=array-bounds]
   273 |       pad[1]->cd();
      |       ~~~~~~~~~~^~
/data/cmsbld/jenkins/workspace/build-any-ib/w/tmp/BUILDROOT/3f7c5ca595fd8634b26b919adc27f210/opt/cmssw/slc7_amd64_gcc11/cms/cmssw/CMSSW_12_1_X_2021-07-30-0900/src/CondCore/EcalPlugins/plugins/EcalFloatCondObjectContainer_PayloadInspector.cc:265:20: note: referencing an object of size 8 allocated by 'void* operator new(std::size_t)'
  265 |       TPad** pad = new TPad*;
      |                    ^~~~~~~~~
  /data/cmsbld/jenkins/workspace/build-any-ib/w/tmp/BUILDROOT/3f7c5ca595fd8634b26b919adc27f210/opt/cmssw/slc7_amd64_gcc11/cms/cmssw/CMSSW_12_1_X_2021-07-30-0900/src/CondCore/EcalPlugins/plugins/EcalFloatCondObjectContainer_PayloadInspector.cc:275:17: error: array subscript 2 is outside array bounds of 'TPad* [1]' [-Werror=array-bounds]
   275 |       pad[2]->cd();
      |       ~~~~~~~~~~^~
/data/cmsbld/jenkins/workspace/build-any-ib/w/tmp/BUILDROOT/3f7c5ca595fd8634b26b919adc27f210/opt/cmssw/slc7_amd64_gcc11/cms/cmssw/CMSSW_12_1_X_2021-07-30-0900/src/CondCore/EcalPlugins/plugins/EcalFloatCondObjectContainer_PayloadInspector.cc:265:20: note: referencing an object of size 8 allocated by 'void* operator new(std::size_t)'
  265 |       TPad** pad = new TPad*;
      |                    ^~~~~~~~~

PR description:

PR validation:

if this PR is a backport please specify the original PR and why you need to backport that PR:

Before submitting your pull requests, make sure you followed this checklist:

Log file: https://cmssdt.cern.ch/SDT/cgi-bin/buildlogs/slc7_amd64_gcc11/CMSSW_12_1_X_2021-07-30-0900/CondCore/EcalPlugins
Error message:
```
/data/cmsbld/jenkins/workspace/build-any-ib/w/tmp/BUILDROOT/3f7c5ca595fd8634b26b919adc27f210/opt/cmssw/slc7_amd64_gcc11/cms/cmssw/CMSSW_12_1_X_2021-07-30-0900/src/CondCore/EcalPlugins/plugins/EcalFloatCondObjectContainer_PayloadInspector.cc: In member function 'virtual bool {anonymous}::EcalFloatCondObjectContainerPlot::fill(const std::vector<std::tuple<long long unsigned int, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > > >&)':
  /data/cmsbld/jenkins/workspace/build-any-ib/w/tmp/BUILDROOT/3f7c5ca595fd8634b26b919adc27f210/opt/cmssw/slc7_amd64_gcc11/cms/cmssw/CMSSW_12_1_X_2021-07-30-0900/src/CondCore/EcalPlugins/plugins/EcalFloatCondObjectContainer_PayloadInspector.cc:120:17: error: array subscript 1 is outside array bounds of 'TPad* [1]' [-Werror=array-bounds]
   120 |       pad[1]->cd();
      |       ~~~~~~~~~~^~
/data/cmsbld/jenkins/workspace/build-any-ib/w/tmp/BUILDROOT/3f7c5ca595fd8634b26b919adc27f210/opt/cmssw/slc7_amd64_gcc11/cms/cmssw/CMSSW_12_1_X_2021-07-30-0900/src/CondCore/EcalPlugins/plugins/EcalFloatCondObjectContainer_PayloadInspector.cc:112:28: note: referencing an object of size 8 allocated by 'void* operator new(std::size_t)'
  112 |       TPad** pad = new TPad*;
      |                            ^
  /data/cmsbld/jenkins/workspace/build-any-ib/w/tmp/BUILDROOT/3f7c5ca595fd8634b26b919adc27f210/opt/cmssw/slc7_amd64_gcc11/cms/cmssw/CMSSW_12_1_X_2021-07-30-0900/src/CondCore/EcalPlugins/plugins/EcalFloatCondObjectContainer_PayloadInspector.cc:122:17: error: array subscript 2 is outside array bounds of 'TPad* [1]' [-Werror=array-bounds]
   122 |       pad[2]->cd();
      |       ~~~~~~~~~~^~
/data/cmsbld/jenkins/workspace/build-any-ib/w/tmp/BUILDROOT/3f7c5ca595fd8634b26b919adc27f210/opt/cmssw/slc7_amd64_gcc11/cms/cmssw/CMSSW_12_1_X_2021-07-30-0900/src/CondCore/EcalPlugins/plugins/EcalFloatCondObjectContainer_PayloadInspector.cc:112:28: note: referencing an object of size 8 allocated by 'void* operator new(std::size_t)'
  112 |       TPad** pad = new TPad*;
      |                            ^
/data/cmsbld/jenkins/workspace/build-any-ib/w/tmp/BUILDROOT/3f7c5ca595fd8634b26b919adc27f210/opt/cmssw/slc7_amd64_gcc11/cms/cmssw/CMSSW_12_1_X_2021-07-30-0900/src/CondCore/EcalPlugins/plugins/EcalFloatCondObjectContainer_PayloadInspector.cc: In member function 'bool {anonymous}::EcalFloatCondObjectContainerDiffBase<nIOVs, ntags>::fill() [with cond::payloadInspector::IOVMultiplicity nIOVs = cond::payloadInspector::SINGLE_IOV; int ntags = 1]':
  /data/cmsbld/jenkins/workspace/build-any-ib/w/tmp/BUILDROOT/3f7c5ca595fd8634b26b919adc27f210/opt/cmssw/slc7_amd64_gcc11/cms/cmssw/CMSSW_12_1_X_2021-07-30-0900/src/CondCore/EcalPlugins/plugins/EcalFloatCondObjectContainer_PayloadInspector.cc:273:17: error: array subscript 1 is outside array bounds of 'TPad* [1]' [-Werror=array-bounds]
   273 |       pad[1]->cd();
      |       ~~~~~~~~~~^~
/data/cmsbld/jenkins/workspace/build-any-ib/w/tmp/BUILDROOT/3f7c5ca595fd8634b26b919adc27f210/opt/cmssw/slc7_amd64_gcc11/cms/cmssw/CMSSW_12_1_X_2021-07-30-0900/src/CondCore/EcalPlugins/plugins/EcalFloatCondObjectContainer_PayloadInspector.cc:265:20: note: referencing an object of size 8 allocated by 'void* operator new(std::size_t)'
  265 |       TPad** pad = new TPad*;
      |                    ^~~~~~~~~
  /data/cmsbld/jenkins/workspace/build-any-ib/w/tmp/BUILDROOT/3f7c5ca595fd8634b26b919adc27f210/opt/cmssw/slc7_amd64_gcc11/cms/cmssw/CMSSW_12_1_X_2021-07-30-0900/src/CondCore/EcalPlugins/plugins/EcalFloatCondObjectContainer_PayloadInspector.cc:275:17: error: array subscript 2 is outside array bounds of 'TPad* [1]' [-Werror=array-bounds]
   275 |       pad[2]->cd();
      |       ~~~~~~~~~~^~
/data/cmsbld/jenkins/workspace/build-any-ib/w/tmp/BUILDROOT/3f7c5ca595fd8634b26b919adc27f210/opt/cmssw/slc7_amd64_gcc11/cms/cmssw/CMSSW_12_1_X_2021-07-30-0900/src/CondCore/EcalPlugins/plugins/EcalFloatCondObjectContainer_PayloadInspector.cc:265:20: note: referencing an object of size 8 allocated by 'void* operator new(std::size_t)'
  265 |       TPad** pad = new TPad*;
      |                    ^~~~~~~~~
/data/cmsbld/jenkins/workspace/build-any-ib/w/tmp/BUILDROOT/3f7c5ca595fd8634b26b919adc27f210/opt/cmssw/slc7_amd64_gcc11/cms/cmssw/CMSSW_12_1_X_2021-07-30-0900/src/CondCore/EcalPlugins/plugins/EcalFloatCondObjectContainer_PayloadInspector.cc: In member function 'bool {anonymous}::EcalFloatCondObjectContainerDiffBase<nIOVs, ntags>::fill() [with cond::payloadInspector::IOVMultiplicity nIOVs = cond::payloadInspector::SINGLE_IOV; int ntags = 2]':
  /data/cmsbld/jenkins/workspace/build-any-ib/w/tmp/BUILDROOT/3f7c5ca595fd8634b26b919adc27f210/opt/cmssw/slc7_amd64_gcc11/cms/cmssw/CMSSW_12_1_X_2021-07-30-0900/src/CondCore/EcalPlugins/plugins/EcalFloatCondObjectContainer_PayloadInspector.cc:273:17: error: array subscript 1 is outside array bounds of 'TPad* [1]' [-Werror=array-bounds]
   273 |       pad[1]->cd();
      |       ~~~~~~~~~~^~
/data/cmsbld/jenkins/workspace/build-any-ib/w/tmp/BUILDROOT/3f7c5ca595fd8634b26b919adc27f210/opt/cmssw/slc7_amd64_gcc11/cms/cmssw/CMSSW_12_1_X_2021-07-30-0900/src/CondCore/EcalPlugins/plugins/EcalFloatCondObjectContainer_PayloadInspector.cc:265:20: note: referencing an object of size 8 allocated by 'void* operator new(std::size_t)'
  265 |       TPad** pad = new TPad*;
      |                    ^~~~~~~~~
  /data/cmsbld/jenkins/workspace/build-any-ib/w/tmp/BUILDROOT/3f7c5ca595fd8634b26b919adc27f210/opt/cmssw/slc7_amd64_gcc11/cms/cmssw/CMSSW_12_1_X_2021-07-30-0900/src/CondCore/EcalPlugins/plugins/EcalFloatCondObjectContainer_PayloadInspector.cc:275:17: error: array subscript 2 is outside array bounds of 'TPad* [1]' [-Werror=array-bounds]
   275 |       pad[2]->cd();
      |       ~~~~~~~~~~^~
/data/cmsbld/jenkins/workspace/build-any-ib/w/tmp/BUILDROOT/3f7c5ca595fd8634b26b919adc27f210/opt/cmssw/slc7_amd64_gcc11/cms/cmssw/CMSSW_12_1_X_2021-07-30-0900/src/CondCore/EcalPlugins/plugins/EcalFloatCondObjectContainer_PayloadInspector.cc:265:20: note: referencing an object of size 8 allocated by 'void* operator new(std::size_t)'
  265 |       TPad** pad = new TPad*;
      |                    ^~~~~~~~~
```
@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 4, 2021

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34757/24422

  • This PR adds an extra 16KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 4, 2021

A new Pull Request was created by @iarspider for master.

It involves the following packages:

  • CondCore/EcalPlugins (db)

@ggovi, @cmsbuild can you please review it and eventually sign? Thanks.
@rchatter, @simonepigazzini, @mmusich, @thomreis, @argiro this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy, @perrotta you are the release manager for this.

cms-bot commands are listed here

@iarspider
Copy link
Contributor Author

@cmsbuild please test for slc7_amd64_gcc11

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 4, 2021

-1

Failed Tests: Build
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-089c98/17514/summary.html
COMMIT: e9a5cb6
CMSSW: CMSSW_12_1_X_2021-08-02-1100/slc7_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/34757/17514/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-089c98/17514/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-089c98/17514/git-merge-result

Build

I found compilation error when building:

/cvmfs/cms-ib.cern.ch/nweek-02692/slc7_amd64_gcc11/external/gcc/11.1.0/bin/../lib/gcc/x86_64-unknown-linux-gnu/11.1.1/../../../../x86_64-unknown-linux-gnu/bin/ld: cannot find -lHeterogeneousCoreCUDACore
/cvmfs/cms-ib.cern.ch/nweek-02692/slc7_amd64_gcc11/external/gcc/11.1.0/bin/../lib/gcc/x86_64-unknown-linux-gnu/11.1.1/../../../../x86_64-unknown-linux-gnu/bin/ld: cannot find -lCUDADataFormatsHGCal
/cvmfs/cms-ib.cern.ch/nweek-02692/slc7_amd64_gcc11/external/gcc/11.1.0/bin/../lib/gcc/x86_64-unknown-linux-gnu/11.1.1/../../../../x86_64-unknown-linux-gnu/bin/ld: cannot find -lHeterogeneousCoreCUDAServices
/cvmfs/cms-ib.cern.ch/nweek-02692/slc7_amd64_gcc11/external/gcc/11.1.0/bin/../lib/gcc/x86_64-unknown-linux-gnu/11.1.1/../../../../x86_64-unknown-linux-gnu/bin/ld: cannot find -lCUDADataFormatsCommon
/cvmfs/cms-ib.cern.ch/nweek-02692/slc7_amd64_gcc11/external/gcc/11.1.0/bin/../lib/gcc/x86_64-unknown-linux-gnu/11.1.1/../../../../x86_64-unknown-linux-gnu/bin/ld: cannot find -lHeterogeneousCoreCUDAUtilities
collect2: error: ld returned 1 exit status
gmake: *** [tmp/slc7_amd64_gcc11/src/CondFormats/HGCalObjects/src/CondFormatsHGCalObjects/libCondFormatsHGCalObjects.so] Error 1
Leaving library rule at CondFormats/HGCalObjects
>> Leaving Package CondFormats/HGCalObjects
>> Package CondFormats/HGCalObjects built
>> Entering Package DQM/SiPixelPhase1Summary


@smuzaffar
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 4, 2021

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-089c98/17537/summary.html
COMMIT: e9a5cb6
CMSSW: CMSSW_12_1_X_2021-08-03-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/34757/17537/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 39
  • DQMHistoTests: Total histograms compared: 2998564
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2998541
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 38 files compared)
  • Checked 165 log files, 37 edm output root files, 39 DQM output files
  • TriggerResults: no differences found

@qliphy
Copy link
Contributor

qliphy commented Aug 10, 2021

kindly ping @cms-sw/db-l2

@ggovi
Copy link
Contributor

ggovi commented Aug 10, 2021

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 927d78d into cms-sw:master Aug 10, 2021
@iarspider iarspider deleted the patch-3 branch August 11, 2021 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants