Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Misc2][clang-tidy] make deleted function public #34691

Merged
merged 2 commits into from
Aug 3, 2021
Merged

[Misc2][clang-tidy] make deleted function public #34691

merged 2 commits into from
Aug 3, 2021

Conversation

smuzaffar
Copy link
Contributor

Cleanup for clang-tidy warning deleted member function should be public [modernize-use-equals-delete]

@cmsbuild cmsbuild added this to the CMSSW_12_0_X milestone Jul 29, 2021
@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34691/24316

  • This PR adds an extra 212KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @smuzaffar (Malik Shahzad Muzaffar) for master.

It involves the following packages:

  • CalibCalorimetry/EcalTrivialCondModules (alca)
  • CalibCalorimetry/HcalTPGAlgos (l1, alca)
  • CalibTracker/SiStripESProducers (alca)
  • CaloOnlineTools/HcalOnlineDb (db)
  • DQM/SiStripCommissioningSources (dqm)
  • DQM/SiStripCommon (dqm)
  • DQMOffline/Trigger (dqm)
  • DQMServices/FwkIO (dqm)
  • EventFilter/GctRawToDigi (l1)
  • EventFilter/L1TRawToDigi (l1)
  • EventFilter/L1TXRawToDigi (l1)
  • EventFilter/RctRawToDigi (l1)
  • EventFilter/SiStripRawToDigi (reconstruction)
  • GeneratorInterface/Herwig7Interface (generators)
  • GeneratorInterface/HiGenCommon (generators)
  • GeneratorInterface/LHEInterface (generators)
  • GeometryReaders/XMLIdealGeometryESSource (geometry)
  • IOMC/EventVertexGenerators (simulation)
  • IOPool/Output (core)

@SiewYan, @andrius-k, @jpata, @ianna, @Saptaparna, @rekovic, @tlampen, @alberto-sanchez, @pohsun, @cecilecaillol, @perrotta, @civanch, @yuanchao, @makortel, @ErnestaP, @ahmad3213, @cmsbuild, @agrohsje, @GurpreetSinghChahal, @smuzaffar, @Dr15Jones, @cvuosalo, @mdhildreth, @jfernan2, @slava77, @ggovi, @francescobrivio, @malbouis, @mkirsano, @kmaeshima, @tvami, @rvenditti can you please review it and eventually sign? Thanks.
@erikbutz, @echabert, @HuguesBrun, @pieterdavid, @robervalwalsh, @argiro, @Martin-Grunewald, @bsunanda, @wddgit, @thomreis, @alberto-sanchez, @threus, @cericeci, @hdelanno, @battibass, @makortel, @abdoulline, @cbaus, @jhgoh, @missirol, @sscruz, @simonepigazzini, @trocino, @rociovilar, @barvic, @sroychow, @tocheng, @VinInn, @jandrea, @idebruyn, @mmusich, @mtosi, @fabiocos, @arossi83, @mkirsano, @rchatter, @jan-kaspar, @gbenelli, @Fedespring, @calderona, @dinyar, @fioriNTU this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy, @perrotta you are the release manager for this.

cms-bot commands are listed here

@smuzaffar
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

-1

Failed Tests: RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-12f9ad/17336/summary.html
COMMIT: 77f04ba
CMSSW: CMSSW_12_0_X_2021-07-28-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/34691/17336/install.sh to create a dev area with all the needed externals and cmssw changes.

CMS StaticAnalyzer warnings: There are 3 inherits from legacy modules warnings. See https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-12f9ad/17336/llvm-analysis/legacy-mod-sa.txt for details.

RelVals-INPUT

  • 11605.011605.0_SingleGammaPt35+2021+SingleGammaPt35_pythia8_GenSimINPUT+Digi+Reco+HARVEST+ALCA/step2_SingleGammaPt35+2021+SingleGammaPt35_pythia8_GenSimINPUT+Digi+Reco+HARVEST+ALCA.log
  • 11601.011601.0_SingleElectronPt10+2021+SingleElectronPt10_pythia8_GenSimINPUT+Digi+Reco+HARVEST+ALCA/step2_SingleElectronPt10+2021+SingleElectronPt10_pythia8_GenSimINPUT+Digi+Reco+HARVEST+ALCA.log
  • 11602.011602.0_SingleElectronPt35+2021+SingleElectronPt35_pythia8_GenSimINPUT+Digi+Reco+HARVEST+ALCA/step2_SingleElectronPt35+2021+SingleElectronPt35_pythia8_GenSimINPUT+Digi+Reco+HARVEST+ALCA.log
Expand to see more relval errors ...

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 7 differences found in the comparisons
  • DQMHistoTests: Total files compared: 39
  • DQMHistoTests: Total histograms compared: 2998564
  • DQMHistoTests: Total failures: 12
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 2998529
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.004 KiB( 38 files compared)
  • DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
  • Checked 165 log files, 37 edm output root files, 39 DQM output files
  • TriggerResults: no differences found

@makortel
Copy link
Contributor

+core

@civanch
Copy link
Contributor

civanch commented Jul 29, 2021

+1

@tvami
Copy link
Contributor

tvami commented Jul 29, 2021

+alca

@smuzaffar smuzaffar modified the milestones: CMSSW_12_0_X, CMSSW_12_1_X Jul 30, 2021
@ggovi
Copy link
Contributor

ggovi commented Jul 30, 2021

+1

@tvami
Copy link
Contributor

tvami commented Jul 30, 2021

@cmsbuild , please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-12f9ad/17370/summary.html
COMMIT: 77f04ba
CMSSW: CMSSW_12_1_X_2021-07-30-0900/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/34691/17370/install.sh to create a dev area with all the needed externals and cmssw changes.

CMS StaticAnalyzer warnings: There are 3 inherits from legacy modules warnings. See https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-12f9ad/17370/llvm-analysis/legacy-mod-sa.txt for details.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 2 differences found in the comparisons
  • DQMHistoTests: Total files compared: 39
  • DQMHistoTests: Total histograms compared: 2998564
  • DQMHistoTests: Total failures: 7
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2998535
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 38 files compared)
  • Checked 165 log files, 37 edm output root files, 39 DQM output files
  • TriggerResults: no differences found

@perrotta
Copy link
Contributor

perrotta commented Aug 2, 2021

@cms-sw/generators-l2 @cms-sw/l1-l2 this looks rather technical, and simple: do you have any commment or complain? Otherwise, we can merge

@perrotta
Copy link
Contributor

perrotta commented Aug 3, 2021

+1
(@cms-sw/l1-l2 @cms-sw/generators-l2 this PR is technical, and changes are quite trivial: just complain in case you have problems with it, and we'll revert it)

@perrotta
Copy link
Contributor

perrotta commented Aug 3, 2021

merge

@cmsbuild cmsbuild merged commit 6a61ea3 into cms-sw:master Aug 3, 2021
@agrohsje
Copy link

agrohsje commented Aug 3, 2021

+generators
as before: a trivial pr but when checking on friday the label was still tests rejected.

This was referenced Aug 4, 2021
Merged
Merged
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
alca-approved code-checks-approved core-approved db-approved dqm-approved generators-approved geometry-approved l1-pending orp-approved pending-signatures reconstruction-approved simulation-approved tests-approved
Projects
None yet
Milestone
CMSSW_12_1_X
Development

Successfully merging this pull request may close these issues.
10 participants
@smuzaffar @cmsbuild @makortel @civanch @slava77 @jfernan2 @tvami @ggovi @perrotta @agrohsje