[GCC 11] Fix error: 'this' pointer is null in Fireworks/Geometry #34764

iarspider · 2021-08-04T12:56:06Z

Log file: https://cmssdt.cern.ch/SDT/cgi-bin/buildlogs/slc7_amd64_gcc11/CMSSW_12_1_X_2021-08-02-1100/Fireworks/Geometry
Error message:

/data/cmsbld/jenkins/workspace/build-any-ib/w/tmp/BUILDROOT/e3e3f354f3bbc00899d20eeb240b2272/opt/cmssw/slc7_amd64_gcc11/cms/cmssw/CMSSW_12_1_X_2021-08-02-1100/src/Fireworks/Geometry/plugins/DisplayGeom.cc: In member function 'virtual void DisplayGeom::analyze(const edm::Event&, const edm::EventSetup&)':
  /data/cmsbld/jenkins/workspace/build-any-ib/w/tmp/BUILDROOT/e3e3f354f3bbc00899d20eeb240b2272/opt/cmssw/slc7_amd64_gcc11/cms/cmssw/CMSSW_12_1_X_2021-08-02-1100/src/Fireworks/Geometry/plugins/DisplayGeom.cc:185:25: error: 'this' pointer is null [-Werror=nonnull]
   185 |         ls->SetLineColor(kGreen);
      |         ~~~~~~~~~~~~~~~~^~~~~~~~

PR description:

PR validation:

if this PR is a backport please specify the original PR and why you need to backport that PR:

Before submitting your pull requests, make sure you followed this checklist:

verify that the PR is really intended for the chosen branch
verify that changes follow CMS Naming, Coding, And Style Rules
verify that the PR passes the basic test procedure suggested in the CMSSW PR instructions

Log file: https://cmssdt.cern.ch/SDT/cgi-bin/buildlogs/slc7_amd64_gcc11/CMSSW_12_1_X_2021-08-02-1100/Fireworks/Geometry Error message: ``` /data/cmsbld/jenkins/workspace/build-any-ib/w/tmp/BUILDROOT/e3e3f354f3bbc00899d20eeb240b2272/opt/cmssw/slc7_amd64_gcc11/cms/cmssw/CMSSW_12_1_X_2021-08-02-1100/src/Fireworks/Geometry/plugins/DisplayGeom.cc: In member function 'virtual void DisplayGeom::analyze(const edm::Event&, const edm::EventSetup&)': /data/cmsbld/jenkins/workspace/build-any-ib/w/tmp/BUILDROOT/e3e3f354f3bbc00899d20eeb240b2272/opt/cmssw/slc7_amd64_gcc11/cms/cmssw/CMSSW_12_1_X_2021-08-02-1100/src/Fireworks/Geometry/plugins/DisplayGeom.cc:185:25: error: 'this' pointer is null [-Werror=nonnull] 185 | ls->SetLineColor(kGreen); | ~~~~~~~~~~~~~~~~^~~~~~~~ ```

cmsbuild · 2021-08-04T13:04:07Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34764/24429

This PR adds an extra 16KB to repository

cmsbuild · 2021-08-04T13:04:27Z

A new Pull Request was created by @iarspider for master.

It involves the following packages:

Fireworks/Geometry (visualization)

@makortel, @alja, @cmsbuild, @Dr15Jones can you please review it and eventually sign? Thanks.
@alja this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy, @perrotta you are the release manager for this.

cms-bot commands are listed here

iarspider · 2021-08-04T13:29:14Z

@cmsbuild please test for slc7_amd64_gcc11

cmsbuild · 2021-08-04T14:42:03Z

-1

Failed Tests: Build
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-30ecd9/17512/summary.html
COMMIT: 9bc2c16
CMSSW: CMSSW_12_1_X_2021-08-02-1100/slc7_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/34764/17512/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-30ecd9/17512/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-30ecd9/17512/git-merge-result

Build

I found compilation error when building:

/cvmfs/cms-ib.cern.ch/nweek-02692/slc7_amd64_gcc11/external/gcc/11.1.0/bin/../lib/gcc/x86_64-unknown-linux-gnu/11.1.1/../../../../x86_64-unknown-linux-gnu/bin/ld: cannot find -lHeterogeneousCoreCUDACore
/cvmfs/cms-ib.cern.ch/nweek-02692/slc7_amd64_gcc11/external/gcc/11.1.0/bin/../lib/gcc/x86_64-unknown-linux-gnu/11.1.1/../../../../x86_64-unknown-linux-gnu/bin/ld: cannot find -lCUDADataFormatsHGCal
/cvmfs/cms-ib.cern.ch/nweek-02692/slc7_amd64_gcc11/external/gcc/11.1.0/bin/../lib/gcc/x86_64-unknown-linux-gnu/11.1.1/../../../../x86_64-unknown-linux-gnu/bin/ld: cannot find -lHeterogeneousCoreCUDAServices
/cvmfs/cms-ib.cern.ch/nweek-02692/slc7_amd64_gcc11/external/gcc/11.1.0/bin/../lib/gcc/x86_64-unknown-linux-gnu/11.1.1/../../../../x86_64-unknown-linux-gnu/bin/ld: cannot find -lCUDADataFormatsCommon
/cvmfs/cms-ib.cern.ch/nweek-02692/slc7_amd64_gcc11/external/gcc/11.1.0/bin/../lib/gcc/x86_64-unknown-linux-gnu/11.1.1/../../../../x86_64-unknown-linux-gnu/bin/ld: cannot find -lHeterogeneousCoreCUDAUtilities
collect2: error: ld returned 1 exit status
gmake: *** [tmp/slc7_amd64_gcc11/src/CondFormats/HGCalObjects/src/CondFormatsHGCalObjects/libCondFormatsHGCalObjects.so] Error 1
Leaving library rule at CondFormats/HGCalObjects
>> Leaving Package CondFormats/HGCalObjects
>> Package CondFormats/HGCalObjects built
>> Entering Package DQM/SiPixelPhase1Summary

smuzaffar · 2021-08-04T15:08:56Z

please test

alja · 2021-08-04T16:43:43Z

+1

cmsbuild · 2021-08-04T16:44:07Z

This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy, @perrotta (and backports should be raised in the release meeting by the corresponding L2)

cmsbuild · 2021-08-04T19:14:24Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-30ecd9/17534/summary.html
COMMIT: 9bc2c16
CMSSW: CMSSW_12_1_X_2021-08-03-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/34764/17534/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

@cms-tsg-storm HLT menu migration to CMSSW 12_0_0_pre5 template [12_1_X] #34740
@zuoxunwu Online DQM: Add EMTF DQM plots on GEM information and their comparison to CSC inputs #34706
@smuzaffar [EventFilter] header cleanup to avoid private header usage #34739

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-30ecd9/17534/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-30ecd9/17534/git-merge-result

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 39
DQMHistoTests: Total histograms compared: 2998558
DQMHistoTests: Total failures: 5
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2998531
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 13814.586 KiB( 38 files compared)
DQMHistoSizes: changed ( 10024.0,... ): 767.477 KiB L1T/L1TStage2EMTF
Checked 165 log files, 37 edm output root files, 39 DQM output files
TriggerResults: found differences in 4 / 38 workflows

perrotta · 2021-08-04T20:27:11Z

+1

cmsbuild added this to the CMSSW_12_1_X milestone Aug 4, 2021

cmsbuild added code-checks-pending orp-pending pending-signatures tests-pending visualization-pending labels Aug 4, 2021

cmsbuild added code-checks-approved and removed code-checks-pending labels Aug 4, 2021

iarspider changed the title ~~[GCC 11] Fix error: 'this' pointer is null~~ [GCC 11] Fix error: 'this' pointer is null n Aug 4, 2021

iarspider changed the title ~~[GCC 11] Fix error: 'this' pointer is null n~~ [GCC 11] Fix error: 'this' pointer is null in Fireworks/Geometry Aug 4, 2021

cmsbuild added tests-started tests-rejected and removed tests-pending tests-started labels Aug 4, 2021

cmsbuild added tests-started and removed tests-rejected labels Aug 4, 2021

cmsbuild added fully-signed visualization-approved and removed pending-signatures visualization-pending labels Aug 4, 2021

cmsbuild removed the tests-started label Aug 4, 2021

cmsbuild added the tests-approved label Aug 4, 2021

cmsbuild added orp-approved and removed orp-pending labels Aug 4, 2021

cmsbuild merged commit 488f5c8 into cms-sw:master Aug 4, 2021

iarspider deleted the patch-5 branch August 4, 2021 20:45

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[GCC 11] Fix error: 'this' pointer is null in Fireworks/Geometry #34764

[GCC 11] Fix error: 'this' pointer is null in Fireworks/Geometry #34764

iarspider commented Aug 4, 2021

cmsbuild commented Aug 4, 2021

cmsbuild commented Aug 4, 2021

iarspider commented Aug 4, 2021

cmsbuild commented Aug 4, 2021

smuzaffar commented Aug 4, 2021

alja commented Aug 4, 2021

cmsbuild commented Aug 4, 2021

cmsbuild commented Aug 4, 2021

perrotta commented Aug 4, 2021

[GCC 11] Fix error: 'this' pointer is null in Fireworks/Geometry #34764

[GCC 11] Fix error: 'this' pointer is null in Fireworks/Geometry #34764

Conversation

iarspider commented Aug 4, 2021

PR description:

PR validation:

if this PR is a backport please specify the original PR and why you need to backport that PR:

cmsbuild commented Aug 4, 2021

cmsbuild commented Aug 4, 2021

iarspider commented Aug 4, 2021

cmsbuild commented Aug 4, 2021

Build

smuzaffar commented Aug 4, 2021

alja commented Aug 4, 2021

cmsbuild commented Aug 4, 2021

cmsbuild commented Aug 4, 2021

Comparison Summary

perrotta commented Aug 4, 2021