-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update DQM onlinebeammonitor #34719
Update DQM onlinebeammonitor #34719
Conversation
@cmsbuild please test |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34719/24358
|
A new Pull Request was created by @francescobrivio for master. It involves the following packages:
@andrius-k, @kmaeshima, @ErnestaP, @ahmad3213, @jfernan2, @rvenditti can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
DQM/Integration/python/clients/onlinebeammonitor_dqm_sourceclient-live_cfg.py
Show resolved
Hide resolved
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34719/24364
|
Pull request #34719 was updated. @andrius-k, @kmaeshima, @ErnestaP, @ahmad3213, @cmsbuild, @jfernan2, @rvenditti can you please check and sign again. |
@cmsbuild please test |
-1 Failed Tests: RelVals-INPUT RelVals-INPUT
Expand to see more relval errors ...
Comparison SummarySummary:
|
BTW this also failed in 12_0_X (#34726 (comment)) but not in 11_3_X (#34721 (comment)). |
@cmsbuild please test |
Those RelVal Input tests are failing quite often, also in unrelated PR. |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c4f9d2/17451/summary.html Comparison SummaryThe workflows 140.53 have different files in step1_dasquery.log than the ones found in the baseline. You may want to check and retrigger the tests if necessary. You can check it in the "files" directory in the results of the comparisons Summary:
|
Failures are:
|
@francescobrivio see #34719 (comment): |
From #34719 (comment)
|
FYI the DQM team has also tested the 11_3_X backport live in their playback system in P5 and found no problems, |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy, @perrotta (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
Fixes #34717.
Added a VPSet to
process.GlobalTag
inonlinebeammonitor_dqm_sourceclient-live_cfg.py
DQM client:In this way the information about BeamSpotOnline is fetched every lumisection and the monitoring
actually reflects the behaviour of any other consumer of these tags (most notably the HLT).
Note that only the record name is needed in the toGet, this makes the client configuration resilient for
future changes of the tag names themselves.
PR validation:
Compiles.
Also tested online and deployed the same configuration change in the HLT cosmics menu running in P5 (see http://cmsonline.cern.ch/cms-elog/1121707).
Backport
Backports to 12_0_X (needed for CRAFT and BeamTest) and 11_3_X (for CRUZET) will be previded shortly.