[Sim][clang-tidy] make deleted function public

[smuzaffar]

Cleanup for clang-tidy warning deleted member function should be public [modernize-use-equals-delete]

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34683/24306

• This PR adds an extra 52KB to repository

[cmsbuild]

A new Pull Request was created by @smuzaffar (Malik Shahzad Muzaffar) for master.

It involves the following packages:

• SimDataFormats/Associations (simulation)
• SimDataFormats/GeneratorProducts (generators)
• SimG4CMS/Calo (simulation)
• SimG4CMS/Forward (simulation)
• SimG4CMS/HGCalTestBeam (upgrade, simulation)
• SimG4CMS/HcalTestBeam (simulation)
• SimG4CMS/ShowerLibraryProducer (simulation)
• SimG4Core/CheckSecondary (simulation)
• SimG4Core/HelpfulWatchers (simulation)
• SimGeneral/MixingModule (simulation)
• SimMuon/MCTruth (simulation)
• SimTracker/Common (simulation)
• SimTracker/TrackerMaterialAnalysis (simulation)

@SiewYan, @civanch, @mkirsano, @Saptaparna, @cmsbuild, @GurpreetSinghChahal, @srimanob, @mdhildreth, @agrohsje, @kpedro88, @alberto-sanchez can you please review it and eventually sign? Thanks.
@echabert, @felicepantaleo, @pieterdavid, @robervalwalsh, @bsunanda, @thomreis, @threus, @mmusich, @slomeo, @battibass, @makortel, @JanFSchulte, @jhgoh, @dgulhan, @apsallid, @prolay, @sscruz, @cericeci, @simonepigazzini, @trocino, @abbiendi, @cvuosalo, @GiacomoSguazzoni, @rovere, @VinInn, @ebrondol, @mtosi, @fabiocos, @HuguesBrun, @vargasa, @gbenelli, @Fedespring, @calderona, @lecriste this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy, @perrotta you are the release manager for this.

cms-bot commands are listed here

[perrotta]

please test

[cmsbuild]

-1

Failed Tests: RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f486c3/17328/summary.html
COMMIT: 8c4cfba
CMSSW: CMSSW_12_0_X_2021-07-28-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/34683/17328/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals-INPUT

• 11630.011630.0_QCD_Pt_3000_3500_14TeV+2021+QCD_Pt_3000_3500_14TeV_TuneCUETP8M1_GenSimINPUT+Digi+Reco+HARVEST+ALCA/step2_QCD_Pt_3000_3500_14TeV+2021+QCD_Pt_3000_3500_14TeV_TuneCUETP8M1_GenSimINPUT+Digi+Reco+HARVEST+ALCA.log
• 11601.011601.0_SingleElectronPt10+2021+SingleElectronPt10_pythia8_GenSimINPUT+Digi+Reco+HARVEST+ALCA/step2_SingleElectronPt10+2021+SingleElectronPt10_pythia8_GenSimINPUT+Digi+Reco+HARVEST+ALCA.log
• 11602.011602.0_SingleElectronPt35+2021+SingleElectronPt35_pythia8_GenSimINPUT+Digi+Reco+HARVEST+ALCA/step2_SingleElectronPt35+2021+SingleElectronPt35_pythia8_GenSimINPUT+Digi+Reco+HARVEST+ALCA.log

Expand to see more relval errors ...

• 11603.0
• 11604.0
• 11605.0
• 11606.0
• 11607.0
• 11608.0
• 11609.0
• 11634.0
• 11634.1
• 11634.24
• 11634.5
• 11634.501
• 11634.505
• 11634.511
• 11634.521
• 11634.91
• 11634.7
• 11640.0
• 11643.0
• 11646.0
• 11650.0
• 11650.501
• 11650.505
• 11723.17
• 11725.0
• 11834.0
• 11834.13
• 11834.24
• 11846.0
• 11925.0
• 12434.0
• 12034.0
• 12634.0
• 12834.0
• 13034.0
• 23434.99
• 23434.21
• 23434.9921
• 34834.21
• 34834.9921

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 7 differences found in the comparisons
• DQMHistoTests: Total files compared: 39
• DQMHistoTests: Total histograms compared: 2998564
• DQMHistoTests: Total failures: 12
• DQMHistoTests: Total nulls: 1
• DQMHistoTests: Total successes: 2998529
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.004 KiB( 38 files compared)
• DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
• Checked 165 log files, 37 edm output root files, 39 DQM output files
• TriggerResults: no differences found

[civanch]

+1

[srimanob]

Please test

Give it another try on PR testing.

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f486c3/17406/summary.html
COMMIT: 8c4cfba
CMSSW: CMSSW_12_1_X_2021-08-01-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/34683/17406/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 6 differences found in the comparisons
• DQMHistoTests: Total files compared: 39
• DQMHistoTests: Total histograms compared: 2998564
• DQMHistoTests: Total failures: 7
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2998535
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 38 files compared)
• Checked 165 log files, 37 edm output root files, 39 DQM output files
• TriggerResults: no differences found

[perrotta]

+1
(@cms-sw/generators-l2 @cms-sw/upgrade-l2 this PR is technical, and changes are quite trivial: just complain in case you have problems with it, and we'll revert it)

[perrotta]

merge

[srimanob]

+Upgrade

[agrohsje]

+generators
Although indeed trivial I didn't want to sign on Friday when the label was still "tests rejected" . All good now.

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged.