[Sim] Move public headers on to interface directory

[smuzaffar]

As reported in #34718 , this PR moves headers in interface directory for Sim*

      2 src/SimCalorimetry/EcalSelectiveReadoutAlgos/src/EcalSelectiveReadout.h
      4 src/SimDataFormats/GeneratorProducts/data/hepev4.inc
      4 src/SimDataFormats/GeneratorProducts/data/stdhep.inc
      1 src/SimMuon/DTDigitizer/test/Histograms.h
      4 src/SimTracker/SiPhase2Digitizer/plugins/Phase2TrackerDigitizerFwd.h
      3 src/SimTracker/TrackAssociation/plugins/CosmicParametersDefinerForTPESProducer.h
      4 src/SimTracker/TrackAssociation/plugins/ParametersDefinerForTPESProducer.h

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34734/24378

• This PR adds an extra 64KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34734/24378/code-format.patch
  e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34734/24378/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[smuzaffar]

code-checks

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34734/24379

• This PR adds an extra 64KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34734/24379/code-format.patch
  e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34734/24379/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34734/24380

• This PR adds an extra 64KB to repository

[cmsbuild]

A new Pull Request was created by @smuzaffar (Malik Shahzad Muzaffar) for master.

It involves the following packages:

• DQM/SiTrackerPhase2 (dqm)
• GeneratorInterface/AMPTInterface (generators)
• GeneratorInterface/BeamHaloGenerator (generators)
• GeneratorInterface/Hydjet2Interface (generators)
• GeneratorInterface/HydjetInterface (generators)
• SimCalorimetry/EcalElectronicsEmulation (simulation)
• SimCalorimetry/EcalSelectiveReadoutAlgos (simulation)
• SimDataFormats/GeneratorProducts (generators)
• SimMuon/DTDigitizer (simulation)
• SimTracker/SiPhase2Digitizer (upgrade, simulation)
• Validation/DTRecHits (dqm)
• Validation/MuonDTDigis (dqm)
• Validation/SiTrackerPhase2V (dqm)

@SiewYan, @civanch, @ahmad3213, @mkirsano, @kmaeshima, @andrius-k, @Saptaparna, @ErnestaP, @cmsbuild, @AdrianoDee, @srimanob, @jfernan2, @agrohsje, @kpedro88, @mdhildreth, @alberto-sanchez, @GurpreetSinghChahal, @rvenditti can you please review it and eventually sign? Thanks.
@argiro, @bsunanda, @thomreis, @alberto-sanchez, @threus, @mmusich, @slomeo, @battibass, @cbaus, @JanFSchulte, @jhgoh, @dgulhan, @apsallid, @simonepigazzini, @sroychow, @GiacomoSguazzoni, @rovere, @VinInn, @ebrondol, @mtosi, @fabiocos, @arossi83, @mkirsano, @rchatter, @lecriste this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy, @perrotta you are the release manager for this.

cms-bot commands are listed here

[smuzaffar]

please test

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34734/24381

• This PR adds an extra 64KB to repository

[cmsbuild]

-1

Failed Tests: RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d9a4be/17442/summary.html
COMMIT: 63b4b43
CMSSW: CMSSW_12_1_X_2021-08-02-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/34734/17442/install.sh to create a dev area with all the needed externals and cmssw changes.

CMS StaticAnalyzer warnings: There are 1 EventSetupRecord::get warnings. See https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d9a4be/17442/llvm-analysis/esrget-sa.txt for details.

RelVals-INPUT

• 11603.011603.0_SingleElectronPt1000+2021+SingleElectronPt1000_pythia8_GenSimINPUT+Digi+Reco+HARVEST+ALCA/step2_SingleElectronPt1000+2021+SingleElectronPt1000_pythia8_GenSimINPUT+Digi+Reco+HARVEST+ALCA.log
• 11601.011601.0_SingleElectronPt10+2021+SingleElectronPt10_pythia8_GenSimINPUT+Digi+Reco+HARVEST+ALCA/step2_SingleElectronPt10+2021+SingleElectronPt10_pythia8_GenSimINPUT+Digi+Reco+HARVEST+ALCA.log
• 11602.011602.0_SingleElectronPt35+2021+SingleElectronPt35_pythia8_GenSimINPUT+Digi+Reco+HARVEST+ALCA/step2_SingleElectronPt35+2021+SingleElectronPt35_pythia8_GenSimINPUT+Digi+Reco+HARVEST+ALCA.log

Expand to see more relval errors ...

• 11604.0
• 11605.0
• 11606.0
• 11607.0
• 11608.0
• 11609.0
• 11630.0
• 11634.0
• 11634.1
• 11634.24
• 11634.5
• 11634.501
• 11634.505
• 11634.511
• 11646.0
• 11725.0
• 11834.0
• 11634.521
• 11634.7
• 11634.91
• 11640.0
• 11643.0
• 11650.0
• 11650.501
• 11650.505
• 11723.17
• 11834.13
• 11834.24
• 11846.0
• 11925.0
• 12034.0
• 12434.0
• 12634.0
• 12834.0
• 13034.0
• 23434.21
• 23434.99
• 23434.9921
• 34834.21
• 34834.9921

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 39
• DQMHistoTests: Total histograms compared: 2998564
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2998541
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 38 files compared)
• Checked 165 log files, 37 edm output root files, 39 DQM output files
• TriggerResults: no differences found

[civanch]

+1

[jfernan2]

+1

[agrohsje]

+generators
failure unrelated to the pr

[srimanob]

+Upgrade

For the upgrade part, SimTracker/SiPhase2Digitizer
FYI @cms-sw/trk-dpg-l2

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (but tests are reportedly failing). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy, @perrotta (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1

[perrotta]

merge