[Fireworks][Clang-tidy] make deleted function public

[smuzaffar]

We have over 25K clang-tidy warnings about deleted member function should be public [modernize-use-equals-delete]. 7.5K of these come from Fireworks sub-system.
Locally tested, it build and all of the modernize-use-equals-delete warnings are fixed.

[a]

Fireworks/Core/interface/FWGenericParameter.h:78:3: warning: deleted member function should be public [modernize-use-equals-delete]
  FWGenericParameter(const FWGenericParameter&) = delete;                   // stop default
  ^
Fireworks/Core/interface/FWGenericParameter.h:79:29: warning: deleted member function should be public [modernize-use-equals-delete]
  const FWGenericParameter& operator=(const FWGenericParameter&) = delete;  // stop default
                            ^
Fireworks/Core/interface/FWParameterBase.h:47:3: warning: deleted member function should be public [modernize-use-equals-delete]
  FWParameterBase(const FWParameterBase&) = delete;                   // stop default
  ^
Fireworks/Core/interface/FWParameterBase.h:48:26: warning: deleted member function should be public [modernize-use-equals-delete]
  const FWParameterBase& operator=(const FWParameterBase&) = delete;  // stop default

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34665/24282

• This PR adds an extra 492KB to repository

[cmsbuild]

A new Pull Request was created by @smuzaffar (Malik Shahzad Muzaffar) for master.

It involves the following packages:

• Fireworks/Calo (visualization)
• Fireworks/Candidates (visualization)
• Fireworks/Core (visualization)
• Fireworks/Electrons (visualization)
• Fireworks/FWInterface (visualization)
• Fireworks/GenParticle (visualization)
• Fireworks/Geometry (visualization)
• Fireworks/Muons (visualization)
• Fireworks/ParticleFlow (visualization)
• Fireworks/SimData (visualization)
• Fireworks/TableWidget (visualization)
• Fireworks/Tracks (visualization)
• Fireworks/Vertices (visualization)

@makortel, @alja, @cmsbuild, @Dr15Jones can you please review it and eventually sign? Thanks.
@alja this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy, @perrotta you are the release manager for this.

cms-bot commands are listed here

[smuzaffar]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-96cd39/17296/summary.html
COMMIT: 942ef9e
CMSSW: CMSSW_12_0_X_2021-07-27-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/34665/17296/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 2 differences found in the comparisons
• DQMHistoTests: Total files compared: 39
• DQMHistoTests: Total histograms compared: 2998564
• DQMHistoTests: Total failures: 7
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2998535
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 38 files compared)
• Checked 165 log files, 37 edm output root files, 39 DQM output files
• TriggerResults: no differences found

[alja]

+1 Thank You!

[perrotta]

+1
(I take #34665 (comment) as a signature for visualization, even if it did not trigger a change of state)

[perrotta]

merge