Skip to content
This repository has been archived by the owner on Dec 13, 2022. It is now read-only.

fix(web): fix the comment deletion for host monitored by poller (#11138) #11483

Closed
wants to merge 429 commits into from
Closed

fix(web): fix the comment deletion for host monitored by poller (#11138) #11483

wants to merge 429 commits into from

Conversation

callapa
Copy link
Contributor

@callapa callapa commented Aug 2, 2022

Description

Backport of this PR: https://github.com/centreon/centreon/pull/11138
The function GetMyHostPoller deals with a host name and not a host id.
So we have to send the host name related to the comment we want to delete.

Fixes MON-12828

Type of change

  • Patch fixing an issue (non-breaking change)
  • New functionality (non-breaking change)
  • Breaking change (patch or feature) that might cause side effects breaking part of the Software

Target serie

  • 21.04.x
  • 21.10.x
  • 22.04.x
  • 22.10.x (master)

Checklist

Community contributors & Centreon team

  • I have followed the coding style guidelines provided by Centreon
  • I have commented my code, especially new classes, functions or any legacy code modified. (docblock)
  • I have commented my code, especially hard-to-understand areas of the PR.
  • I have rebased my development branch on the base branch (master, maintenance).

Thebarda and others added 30 commits October 15, 2021 17:06
@Thebarda
fix(UI): Fix options duplication on dynamic filters (#10288)
4ad473d 
* Fix options duplication

* Improve option selected code

* Fix filter tests
@tuntoja
Fix unattended script repo (#10287)
066d627 
* fix(unattended): change release to 1 instead of 2

* fix(unattended): use remi7 to install php8 on centos7

* fix: revert release rpm version to 2
@Jordan91
Add css style on class container (#10314)
a379e24
@zguennoune02
canary docker (#10317)
57e20ca
@bdauria
fix(Resource-status/Filter): Allow searching for terms named after cr…
d5b44af 
…iterias
@sc979
enh(chore): issueType, feature_team and issue description (#10320)
b7fe363
@Thebarda
enh(UI): Make the duration as second sorting criteria (#10306)
42940ae 
* Add a second sort criteria

* Fix tests

* Refactor for readability
@Thebarda
fix(UI): Fix details tiles local storage (#10312)
9247bf1 
* Fix tiles local storage

* Fix test
@kduret
fix(test): fix broker configuration in acceptance tests (#10321)
8d1d6e7 
Refs: MON-11182
@zguennoune02
manage master as canary (#10324)
48dfa29
@AssanDiomande
fix(php): fix problems related to PHP 8.0 upgrade (#10297)
8db244e 
* problems fixed with PHP 8.0

* fixed centreon-box suggestions

* resolved centreon-bot suggestions

* Delete ldap-test.yml

* Delete log

* Update listImg.ihtml
@adr-mo
enh(resource-status): performance optimizations (#10323)
b5659b5 
* enh(resource-status): escape "_" character to use indexed search

* enh(resources): use EXISTS statement instead of INNER JOIN
@kduret
fix(test): upgrade selenium2Driver and adapt tests (#10333)
234e466
@bdauria
fix(Resource-status/Details/Graph): Fix metaservice endpoint #10332
94f74be
@bdauria
fix(Resource-status): Fix status tiles labels / Fix tile height / Fix…
b35b1f5 
… tile height blowing up (#10310)
@Nohzoh
Add gpg check script for develop branch (#10338)
312734f
@zguennoune02
remove duplication (#10339)
4e32d1b
@Jordan91 @kduret
fix(UI): Re-import-translation-for-button-export-in-one-click (#10340)
8c1a0a1 
* Re-import-translation-for-button-export-in-one-click

* Update messages.po

Co-authored-by: Kevin Duret <kduret@centreon.com>
@Thebarda
Fix the double click (#10313)
39f30c8
@adr-mo @a-launois @callapa
fix(filter): handle name when saving criterias hg/sg (#10330)
5fb626a 
* fix(filter): handle name when saving criterias hg/sg

* fix unit tests

* centreon-bot: fix feedbacks

* Update src/Centreon/Domain/Monitoring/HostGroup/HostGroupService.php

Co-authored-by: alaunois <alaunois@centreon.com>

* Update src/Centreon/Domain/Monitoring/ServiceGroup/Interfaces/ServiceGroupRepositoryInterface.php

Co-authored-by: Laurent Calvet <lcalvet@centreon.com>

* Update src/Centreon/Domain/Monitoring/ServiceGroup/Interfaces/ServiceGroupServiceInterface.php

Co-authored-by: Laurent Calvet <lcalvet@centreon.com>

* Update src/Centreon/Domain/Monitoring/ServiceGroup/Interfaces/ServiceGroupRepositoryInterface.php

Co-authored-by: Laurent Calvet <lcalvet@centreon.com>

* Update src/Centreon/Domain/Monitoring/HostGroup/Interfaces/HostGroupServiceInterface.php

Co-authored-by: Laurent Calvet <lcalvet@centreon.com>

* Update src/Centreon/Domain/Monitoring/HostGroup/Interfaces/HostGroupServiceInterface.php

Co-authored-by: Laurent Calvet <lcalvet@centreon.com>

* Update src/Centreon/Domain/Monitoring/HostGroup/Interfaces/HostGroupRepositoryInterface.php

Co-authored-by: Laurent Calvet <lcalvet@centreon.com>

* Update src/Centreon/Domain/Monitoring/HostGroup/Interfaces/HostGroupRepositoryInterface.php

Co-authored-by: Laurent Calvet <lcalvet@centreon.com>

* Update src/Centreon/Domain/Monitoring/ServiceGroup/Interfaces/ServiceGroupServiceInterface.php

* code-review: take kdus feedback into account

* try to fix API acceptance test

Co-authored-by: alaunois <alaunois@centreon.com>
Co-authored-by: Laurent Calvet <lcalvet@centreon.com>
@Jordan91
Refectoring(ui): Remove submenuType unused (#10334)
b54c61c
@adr-mo
fix(resource): issue with servicegroup SQL request (#10331)
a7e4cc4
@bdauria
enh(Resource-status/Filter): Fix Filter select width (#10319)
da68135 
* Fix filter select width

* Fix loading skeleton width
@bdauria
fix(Resource-status/useRequest): Prevent requests from throwing an er…
e81c635 
…ror when cancelled (#10343)
@AssanDiomande
Removed animation effect option in account parameters (#10329)
b3f2d45 
* add commented line 140 of formMyAccount.php

* remove js effects animation occurences

* fixed error on myFormAccount.php

* add statement to delete contact_js_effects column and fixed psr format

* File restored

* restored files

* delete alter table contact statement

* add sql update script

* edit sql file

* updated sql statement
@adr-mo
fix(downtime): fix error for downtime on hostgroups (#10346)
526ef0a
@kduret
Revert "Removed animation effect option in account parameters (#10329)"
792ac7a 
This reverts commit b3f2d45.
@a-launois
fix(conf) remove option to enable one-click-export button (#10350)
ad4ad49
@kduret
fix(pendo): use api to get pendo information (#10349)
ccb8638 
Refs: MON-10926
@bdauria
fix(Resource-status/Details): Fix Details panel not being refreshed w…
a6884e0 
…hen a Resource is selected #10353
jeremyjaouen and others added 13 commits July 11, 2022 15:52
@jeremyjaouen
Sanitize and bind "service" related queries (#11156) (#11356)
662ba34
@jeremyjaouen
Clean formMyAccount old password saved in session (#11342) (#11359)
0e745a3
@a-launois
fix(conf) fix broker conf name display in listing (#11372) (#11377)
b25c2bf
@callapa
fix(trap): Removal of the restriction on the uniqueness of the OID of…
949283c 
… a trap (#11328)

This PR aims to remove the restriction on the uniqueness of the OID of a trap.
@hyahiaoui-ext
Snyk: Sanitize and bind ACL service dependency queries dev-21.10.x (#…
85048ef 
…11396)
@jeremyjaouen
fix(hostgroup): fix display of hostgroups in select2 (#11431) (#11442)
c5b45fd
@hyahiaoui-ext
Snyk: Sanitize and bind Auth class queries 21.10.x (#11449)
f94c1b2
@hyahiaoui-ext
Snyk: Sanitize and bind media sync queries (#11419)
fd7ff62 
* sanitizing and binding sync dir file queries

* Applying some fixes
@emabassi-ext
Sanitized and bound queries (#11413) (#11445) (#11456)
be19aa8 
lines : 130 -142
@emabassi-ext
[SNYK] Sanitize and bind ACL class queries (#11392) (#11405)
c5c00b2 
* Sanitize and bind ACL class queries

Queries   sanitized  and bound using PDO statement

* fix spaces

spaces between (int) cast and variables

* update file delete spaces after comma

* change variables names due to a review

* Line exceeds 120 characters; contains 123 characters
@emabassi-ext
[SNYK] Sanitize and bind ACL host dependency queries (#11389) (#11394) (
1c341e6 
#11458)

* Sanitize and bind ACL host dependency queries

* fix issues
@emabassi-ext
removed old variable userCrypted and the use of it (#11334) (#11468)
1e4273d
@s-duret @callapa
fix(web): fix the comment deletion for host monitored by poller (#11138)
a14e534 
Refs: MON-12828
@callapa callapa requested review from a team, TamazC and wtermellil and removed request for a team August 2, 2022 12:00
@sonarqube-decoration
Copy link

SonarQube Quality Gate

Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@callapa callapa requested review from a team, bdauria and Thebarda and removed request for a team August 4, 2022 07:44
@bdauria bdauria removed request for bdauria and Thebarda August 9, 2022 09:25
@kduret
Copy link
Contributor

kduret commented Aug 10, 2022

replaced by https://github.com/centreon/centreon/pull/11557

@kduret kduret closed this Aug 10, 2022
@kduret kduret deleted the MON-12828-dev-21.10.x branch August 10, 2022 13:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kduret kduret kduret approved these changes

@TamazC TamazC Awaiting requested review from TamazC

@wtermellil wtermellil Awaiting requested review from wtermellil

Assignees
No one assigned
Labels
area/backend
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.