Skip to content
This repository has been archived by the owner on Dec 13, 2022. It is now read-only.

fix(downtime): fix error for downtime on hostgroups #10346

Merged
merged 1 commit into from
Oct 21, 2021

Conversation

adr-mo
Copy link
Contributor

@adr-mo adr-mo commented Oct 21, 2021

This issue only occurs on 21.10, this is visible now thanks to the php upgrade.

  • 21.04 runs with PHP 7.3, a count on a "null" variable will throw a warning message
  • 21.10 runs with PHP 8.0, a count on a "null" variable will throw a fatal error

Fixes # (issue)

Type of change

  • Patch fixing an issue (non-breaking change)
  • New functionality (non-breaking change)
  • Breaking change (patch or feature) that might cause side effects breaking part of the Software
  • Updating documentation (missing information, typo...)

Target serie

  • 20.04.x
  • 20.10.x
  • 21.04.x
  • 21.10.x (master)

How this pull request can be tested ?

See Jira ticket for details

Checklist

  • I have followed the coding style guidelines provided by Centreon
  • I have commented my code, especially new classes, functions or any legacy code modified. (docblock)
  • I have commented my code, especially hard-to-understand areas of the PR.
  • I have made corresponding changes to the documentation.
  • I have rebased my development branch on the base branch (master, maintenance).

@adr-mo adr-mo requested review from a team, callapa, a-launois and kduret and removed request for a team October 21, 2021 08:57
@sonarqube-decoration
Copy link

SonarQube Quality Gate:
Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@adr-mo adr-mo merged commit 526ef0a into develop Oct 21, 2021
@adr-mo adr-mo deleted the MON-11365-fatal-error-on-downtime-for-hg branch October 21, 2021 09:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants