Skip to content
This repository has been archived by the owner on Dec 13, 2022. It is now read-only.

enh(UI): Make the duration as second sorting criteria #10306

Merged
merged 3 commits into from
Oct 19, 2021
Merged

enh(UI): Make the duration as second sorting criteria #10306

merged 3 commits into from
Oct 19, 2021

Conversation

Thebarda
Copy link
Contributor

Description

This adds the "duration" column as second sorting criteria

Type of change

  • Patch fixing an issue (non-breaking change)
  • New functionality (non-breaking change)
  • Breaking change (patch or feature) that might cause side effects breaking part of the Software
  • Updating documentation (missing information, typo...)

Target serie

  • 20.04.x
  • 20.10.x
  • 21.04.x
  • 21.10.x (master)

How this pull request can be tested ?

  • Have at least 2 resources with the same status
  • Sort resources by status
  • -> Within the same status, the resources are also sorted by duration from the newest to the oldest

Checklist

  • I have followed the coding style guidelines provided by Centreon
  • I have commented my code, especially new classes, functions or any legacy code modified. (docblock)
  • I have commented my code, especially hard-to-understand areas of the PR.
  • I have made corresponding changes to the documentation.
  • I have rebased my development branch on the base branch (master, maintenance).

@Thebarda Thebarda requested review from a team, bdauria and Jordan91 October 14, 2021 13:26
@Thebarda Thebarda requested a review from bdauria October 15, 2021 07:58
@sonarqube-decoration
Copy link

SonarQube Quality Gate:
Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@Thebarda Thebarda merged commit 42940ae into develop Oct 19, 2021
@Thebarda Thebarda deleted the MON-11006-make-duration-as-second-sorting-criteria branch October 19, 2021 07:20
Thebarda added a commit that referenced this pull request Oct 20, 2021
@Thebarda
enh(UI): Make the duration as second sorting criteria (#10306)
ddaf92b 
* Add a second sort criteria

* Fix tests

* Refactor for readability
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Jordan91 Jordan91 Jordan91 approved these changes

@bdauria bdauria bdauria approved these changes

Assignees
No one assigned
Labels
area/ui
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Thebarda @bdauria @Jordan91