Skip to content
This repository has been archived by the owner on Dec 13, 2022. It is now read-only.

Removed animation effect option in account parameters #10329

Merged
merged 11 commits into from
Oct 21, 2021
Merged

Removed animation effect option in account parameters #10329

merged 11 commits into from
Oct 21, 2021

Conversation

AssanDiomande
Copy link
Contributor

Description

Fixes MON-11359

Removed animation effect option in account parameters

Commented line 140 of file www/include/Administration/myAccount/formMyAccount.php

Type of change

  • Patch fixing an issue (non-breaking change)
  • New functionality (non-breaking change)
  • Breaking change (patch or feature) that might cause side effects breaking part of the Software
  • Updating documentation (missing information, typo...)

Target serie

  • 20.04.x
  • 20.10.x
  • 21.04.x
  • 21.10.x (master)

How this pull request can be tested ?

  • Create a downtime for a service who start immediatly
  • Go to Monitoring > Status details > Services
  • Move the cursor on the downtime icon
  • Check if the animation is good or not

@AssanDiomande AssanDiomande requested review from a team, callapa and a-launois October 19, 2021 13:44
@AssanDiomande AssanDiomande changed the title add commented line 140 of formMyAccount.php Removed animation effect option in account parameters Oct 19, 2021
callapa
callapa suggested changes Oct 19, 2021
View reviewed changes
Copy link
Contributor

@callapa callapa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to create an upgrade SQL script that will remove the contact_js_effects column.

www/include/Administration/myAccount/formMyAccount.php Outdated Show resolved Hide resolved
@centreon centreon deleted a comment from centreon-bot Oct 19, 2021
@centreon centreon deleted a comment from centreon-bot Oct 19, 2021
@AssanDiomande AssanDiomande requested a review from callapa October 20, 2021 13:31
callapa
callapa previously approved these changes Oct 20, 2021
View reviewed changes
@AssanDiomande AssanDiomande requested a review from kduret October 21, 2021 07:19
@AssanDiomande AssanDiomande requested a review from callapa October 21, 2021 07:21
@sonarqube-decoration
Copy link

SonarQube Quality Gate:
Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@AssanDiomande AssanDiomande merged commit b3f2d45 into develop Oct 21, 2021
@AssanDiomande AssanDiomande deleted the MON-11359 branch October 21, 2021 08:01
kduret added a commit that referenced this pull request Oct 21, 2021
@kduret
Revert "Removed animation effect option in account parameters (#10329)"
1aeef8d 
This reverts commit b3f2d45.
kduret added a commit that referenced this pull request Oct 21, 2021
@kduret
Revert "Removed animation effect option in account parameters (#10329)"
792ac7a 
This reverts commit b3f2d45.
@AssanDiomande AssanDiomande restored the MON-11359 branch October 21, 2021 11:19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@a-launois a-launois a-launois approved these changes

@kduret kduret kduret approved these changes

@callapa callapa Awaiting requested review from callapa

Assignees
No one assigned
Labels
area/backend
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@AssanDiomande @callapa @kduret @a-launois