Skip to content
This repository has been archived by the owner on Dec 13, 2022. It is now read-only.

fix(UI): Fix details tiles local storage #10312

Merged
merged 2 commits into from
Oct 19, 2021

Conversation

Thebarda
Copy link
Contributor

Description

This display displayable cards although there are some tiles in the local storage
Screenshot 2021-10-15 at 16 32 05

Type of change

  • Patch fixing an issue (non-breaking change)
  • New functionality (non-breaking change)
  • Breaking change (patch or feature) that might cause side effects breaking part of the Software
  • Updating documentation (missing information, typo...)

Target serie

  • 20.04.x
  • 20.10.x
  • 21.04.x
  • 21.10.x (master)

How this pull request can be tested ?

  • Open the resource details
  • Close the panel
  • Open your browser’s console
  • Select the “Application” tab
  • Open your local storage
  • Change the value of the key “centreon-resource-status-details-card-21.10” to ["Status information"]
  • Open a resource details panel
  • -> All the corresponding tiles should be displayed

Checklist

  • I have followed the coding style guidelines provided by Centreon
  • I have commented my code, especially new classes, functions or any legacy code modified. (docblock)
  • I have commented my code, especially hard-to-understand areas of the PR.
  • I have made corresponding changes to the documentation.
  • I have rebased my development branch on the base branch (master, maintenance).

@Thebarda Thebarda requested review from a team, bdauria and jdelpierre October 15, 2021 14:42
@sonarqube-decoration
Copy link

SonarQube Quality Gate:
Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@sonarqube-decoration
Copy link

SonarQube Quality Gate:
Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@Thebarda Thebarda merged commit 9247bf1 into develop Oct 19, 2021
@Thebarda Thebarda deleted the MON-11346-some-tiles-could-not-be-displayed branch October 19, 2021 07:20
Thebarda added a commit that referenced this pull request Oct 20, 2021
* Fix tiles local storage

* Fix test
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants