fix(filter): handle name when saving criterias hg/sg #10330

adr-mo · 2021-10-19T13:58:32Z

This fixes an issue when editing a filter. Front-end does not send the ids anymore but only the names of servicegroups and hostgroups as criterias. this needs to be reflected on backend when an update action is sent for the filter

Fixes # (issue)

Type of change

Patch fixing an issue (non-breaking change)
New functionality (non-breaking change)
Breaking change (patch or feature) that might cause side effects breaking part of the Software
Updating documentation (missing information, typo...)

Target serie

20.04.x
20.10.x
21.04.x
21.10.x (master)

How this pull request can be tested ?

See Jira ticket for details

Checklist

I have followed the coding style guidelines provided by Centreon
I have commented my code, especially new classes, functions or any legacy code modified. (docblock)
I have commented my code, especially hard-to-understand areas of the PR.
I have made corresponding changes to the documentation.
I have rebased my development branch on the base branch (master, maintenance).

src/Centreon/Infrastructure/Monitoring/HostGroup/HostGroupRepositoryRDB.php

src/Centreon/Domain/Monitoring/HostGroup/Interfaces/HostGroupRepositoryInterface.php

src/Centreon/Domain/Monitoring/HostGroup/Interfaces/HostGroupServiceInterface.php

src/Centreon/Domain/Monitoring/ServiceGroup/Interfaces/ServiceGroupRepositoryInterface.php

src/Centreon/Domain/Monitoring/ServiceGroup/Interfaces/ServiceGroupServiceInterface.php

src/Centreon/Domain/Monitoring/HostGroup/HostGroupService.php

Co-authored-by: alaunois <alaunois@centreon.com>

…GroupRepositoryInterface.php Co-authored-by: Laurent Calvet <lcalvet@centreon.com>

…GroupServiceInterface.php Co-authored-by: Laurent Calvet <lcalvet@centreon.com>

…GroupRepositoryInterface.php Co-authored-by: Laurent Calvet <lcalvet@centreon.com>

…erviceInterface.php Co-authored-by: Laurent Calvet <lcalvet@centreon.com>

…epositoryInterface.php Co-authored-by: Laurent Calvet <lcalvet@centreon.com>

src/Centreon/Domain/Monitoring/ServiceGroup/Interfaces/ServiceGroupServiceInterface.php

…GroupServiceInterface.php

sonarqube-decoration · 2021-10-20T13:42:51Z

SonarQube Quality Gate:

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

0.0% Coverage
0.0% Duplication

* fix(filter): handle name when saving criterias hg/sg * fix unit tests * centreon-bot: fix feedbacks * Update src/Centreon/Domain/Monitoring/HostGroup/HostGroupService.php Co-authored-by: alaunois <alaunois@centreon.com> * Update src/Centreon/Domain/Monitoring/ServiceGroup/Interfaces/ServiceGroupRepositoryInterface.php Co-authored-by: Laurent Calvet <lcalvet@centreon.com> * Update src/Centreon/Domain/Monitoring/ServiceGroup/Interfaces/ServiceGroupServiceInterface.php Co-authored-by: Laurent Calvet <lcalvet@centreon.com> * Update src/Centreon/Domain/Monitoring/ServiceGroup/Interfaces/ServiceGroupRepositoryInterface.php Co-authored-by: Laurent Calvet <lcalvet@centreon.com> * Update src/Centreon/Domain/Monitoring/HostGroup/Interfaces/HostGroupServiceInterface.php Co-authored-by: Laurent Calvet <lcalvet@centreon.com> * Update src/Centreon/Domain/Monitoring/HostGroup/Interfaces/HostGroupServiceInterface.php Co-authored-by: Laurent Calvet <lcalvet@centreon.com> * Update src/Centreon/Domain/Monitoring/HostGroup/Interfaces/HostGroupRepositoryInterface.php Co-authored-by: Laurent Calvet <lcalvet@centreon.com> * Update src/Centreon/Domain/Monitoring/HostGroup/Interfaces/HostGroupRepositoryInterface.php Co-authored-by: Laurent Calvet <lcalvet@centreon.com> * Update src/Centreon/Domain/Monitoring/ServiceGroup/Interfaces/ServiceGroupServiceInterface.php * code-review: take kdus feedback into account * try to fix API acceptance test Co-authored-by: alaunois <alaunois@centreon.com> Co-authored-by: Laurent Calvet <lcalvet@centreon.com>

fix(filter): handle name when saving criterias hg/sg

aede33a

adr-mo added the area/backend label Oct 19, 2021

adr-mo requested review from a team, callapa, a-launois and kduret and removed request for a team October 19, 2021 13:58

fix unit tests

9f11ae1

adr-mo requested a review from a team October 19, 2021 15:06

centreon-bot: fix feedbacks

fc1c0e4

kduret reviewed Oct 19, 2021

View reviewed changes

src/Centreon/Infrastructure/Monitoring/HostGroup/HostGroupRepositoryRDB.php Show resolved Hide resolved

callapa reviewed Oct 20, 2021

View reviewed changes

a-launois reviewed Oct 20, 2021

View reviewed changes

src/Centreon/Domain/Monitoring/HostGroup/HostGroupService.php Outdated Show resolved Hide resolved

adr-mo and others added 8 commits October 20, 2021 10:31

Update src/Centreon/Domain/Monitoring/HostGroup/HostGroupService.php

44e5cbb

Co-authored-by: alaunois <alaunois@centreon.com>

Update src/Centreon/Domain/Monitoring/ServiceGroup/Interfaces/Service…

157a744

…GroupRepositoryInterface.php Co-authored-by: Laurent Calvet <lcalvet@centreon.com>

Update src/Centreon/Domain/Monitoring/ServiceGroup/Interfaces/Service…

bc98798

…GroupServiceInterface.php Co-authored-by: Laurent Calvet <lcalvet@centreon.com>

Update src/Centreon/Domain/Monitoring/ServiceGroup/Interfaces/Service…

cc6bf47

…GroupRepositoryInterface.php Co-authored-by: Laurent Calvet <lcalvet@centreon.com>

Update src/Centreon/Domain/Monitoring/HostGroup/Interfaces/HostGroupS…

8f1f418

…erviceInterface.php Co-authored-by: Laurent Calvet <lcalvet@centreon.com>

Update src/Centreon/Domain/Monitoring/HostGroup/Interfaces/HostGroupS…

0ca314a

…erviceInterface.php Co-authored-by: Laurent Calvet <lcalvet@centreon.com>

Update src/Centreon/Domain/Monitoring/HostGroup/Interfaces/HostGroupR…

a8e3764

…epositoryInterface.php Co-authored-by: Laurent Calvet <lcalvet@centreon.com>

Update src/Centreon/Domain/Monitoring/HostGroup/Interfaces/HostGroupR…

4052cf1

…epositoryInterface.php Co-authored-by: Laurent Calvet <lcalvet@centreon.com>

callapa previously approved these changes Oct 20, 2021

View reviewed changes

a-launois previously approved these changes Oct 20, 2021

View reviewed changes

adr-mo commented Oct 20, 2021

View reviewed changes

src/Centreon/Domain/Monitoring/ServiceGroup/Interfaces/ServiceGroupServiceInterface.php Outdated Show resolved Hide resolved

Update src/Centreon/Domain/Monitoring/ServiceGroup/Interfaces/Service…

f7dbb1a

…GroupServiceInterface.php

adr-mo dismissed stale reviews from a-launois and callapa via f7dbb1a October 20, 2021 08:40

a-launois previously approved these changes Oct 20, 2021

View reviewed changes

callapa previously approved these changes Oct 20, 2021

View reviewed changes

code-review: take kdus feedback into account

6e63904

try to fix API acceptance test

82b5690

adr-mo dismissed stale reviews from callapa and a-launois via 82b5690 October 20, 2021 13:35

callapa approved these changes Oct 20, 2021

View reviewed changes

callapa requested review from a-launois and kduret October 20, 2021 14:03

kduret approved these changes Oct 20, 2021

View reviewed changes

adr-mo merged commit 5fb626a into develop Oct 20, 2021

adr-mo deleted the MON-11353-editing-filter-with-dynamic-criterias branch October 20, 2021 14:09

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(filter): handle name when saving criterias hg/sg #10330

fix(filter): handle name when saving criterias hg/sg #10330

adr-mo commented Oct 19, 2021

sonarqube-decoration bot commented Oct 20, 2021

fix(filter): handle name when saving criterias hg/sg #10330

fix(filter): handle name when saving criterias hg/sg #10330

Conversation

adr-mo commented Oct 19, 2021

Type of change

Target serie

How this pull request can be tested ?

Checklist

sonarqube-decoration bot commented Oct 20, 2021