Skip to content
This repository has been archived by the owner on Dec 13, 2022. It is now read-only.

fix(UI): Fix options duplication on dynamic filters #10288

Merged
merged 5 commits into from
Oct 15, 2021
Merged

fix(UI): Fix options duplication on dynamic filters #10288

merged 5 commits into from
Oct 15, 2021

Conversation

Thebarda
Copy link
Contributor

Description

This fixes some duplication on options about dynamic filters.
https://user-images.githubusercontent.com/12515407/137007611-065594ab-d83c-4e69-b402-7958432b2c4e.mov

Type of change

  • Patch fixing an issue (non-breaking change)
  • New functionality (non-breaking change)
  • Breaking change (patch or feature) that might cause side effects breaking part of the Software
  • Updating documentation (missing information, typo...)

Target serie

  • 20.04.x
  • 20.10.x
  • 21.04.x
  • 21.10.x (master)

How this pull request can be tested ?

  • Create several host groups
  • On Resource Status, open filters popin
  • Click on the host groups chip
  • Select a host group
  • -> The host group is selected and is no longer duplicated in the autocomplete options box

Checklist

  • I have followed the coding style guidelines provided by Centreon
  • I have commented my code, especially new classes, functions or any legacy code modified. (docblock)
  • I have commented my code, especially hard-to-understand areas of the PR.
  • I have made corresponding changes to the documentation.
  • I have rebased my development branch on the base branch (master, maintenance).

@Thebarda Thebarda requested review from a team, jdelpierre and Jordan91 October 12, 2021 18:14
jdelpierre
jdelpierre previously approved these changes Oct 13, 2021
View reviewed changes
@sonarqube-decoration
Copy link

SonarQube Quality Gate:
Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@Thebarda Thebarda merged commit 4ad473d into develop Oct 15, 2021
@Thebarda Thebarda deleted the MON-11224-issue-with-dynamic-filters-on-RS branch October 15, 2021 15:06
Thebarda added a commit that referenced this pull request Oct 20, 2021
@Thebarda
fix(UI): Fix options duplication on dynamic filters (#10288)
5ce82bb 
* Fix options duplication

* Improve option selected code

* Fix filter tests
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Jordan91 Jordan91 Jordan91 approved these changes

@jdelpierre jdelpierre jdelpierre approved these changes

Assignees
No one assigned
Labels
area/ui
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Thebarda @jdelpierre @Jordan91