Skip to content
This repository has been archived by the owner on Dec 13, 2022. It is now read-only.

[SNYK] Sanitize and bind ACL host dependency queries (#11389) (#11394) #11458

Merged
merged 1 commit into from
Jul 29, 2022

Conversation

emabassi-ext
Copy link
Contributor

Description

Queries should be sanitized (if possible) and bound using PDO statement to reduce attack surface and clean legacy code

Lines: 130 142 154
www/include/configuration/configObject/host_dependency/DB-Func.php - function
Fixes # MON-14260
PS: Already merged in develope + dev-22.04.x

Type of change

  • Patch fixing an issue (non-breaking change)
  • New functionality (non-breaking change)
  • Breaking change (patch or feature) that might cause side effects breaking part of the Software

Target serie

  • 21.04.x
  • 21.10.x
  • 22.04.x
  • 22.10.x (master)

How this pull request can be tested ?

Configuration > notifications > hosts
Create a dependency between two hosts

Set the host as passive and using the forced status, trigger a notification as expected

Checklist

Community contributors & Centreon team

  • I have followed the coding style guidelines provided by Centreon
  • I have commented my code, especially new classes, functions or any legacy code modified. (docblock)
  • I have commented my code, especially hard-to-understand areas of the PR.
  • I have rebased my development branch on the base branch (master, maintenance).

* Sanitize and bind ACL host dependency queries

* fix issues
@emabassi-ext emabassi-ext requested review from callapa, kduret, jeremyjaouen and a team July 29, 2022 11:28
@emabassi-ext emabassi-ext self-assigned this Jul 29, 2022
@sonarqube-decoration
Copy link

SonarQube Quality Gate

Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell B 6 Code Smells

No Coverage information No Coverage information
58.8% 58.8% Duplication

@emabassi-ext emabassi-ext merged commit 1c341e6 into dev-21.10.x Jul 29, 2022
@emabassi-ext emabassi-ext deleted the MON-14260 branch July 29, 2022 12:13
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants