Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy brave_appearance_page module #860

Merged
merged 1 commit into from
Sep 3, 2018

Conversation

simonhong
Copy link
Member

@simonhong simonhong commented Aug 28, 2018

This module is for adding brave appearance options to settings page.

Issue: #789

This pr should be merged together with brave/brave-core#361

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Verified that these changes build without errors on
    • Windows
    • macOS
    • Linux
  • Verified that these changes pass automated tests (npm test brave_unit_tests && npm test brave_browser_tests) on
    • Windows
    • macOS
    • Linux
  • Ran git rebase master (if needed).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Requested a security/privacy review as needed.

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions.

This module is for adding brave appearnce options to settings page.
@simonhong simonhong self-assigned this Aug 28, 2018
@simonhong simonhong changed the title [WIP] Copy brave_appearance_page module Copy brave_appearance_page module Aug 29, 2018
@simonhong
Copy link
Member Author

Removed wip label. ready to review.

Copy link
Member

@bbondy bbondy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@bbondy bbondy merged commit 25a69f6 into master Sep 3, 2018
@bsclifton bsclifton deleted the copy_brave_appearance_page_module branch September 10, 2018 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants