Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ability to switch between Dark / Light mode #789

Closed
2 tasks done
petemill opened this issue Aug 20, 2018 · 1 comment · Fixed by brave/brave-core#361
Closed
2 tasks done

Ability to switch between Dark / Light mode #789

petemill opened this issue Aug 20, 2018 · 1 comment · Fixed by brave/brave-core#361
Assignees
@simonhong
Labels
feature/user-interface All UI related QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes
Milestone
0.55.x - Release ...

Comments

@petemill
Copy link
Member

petemill commented Aug 20, 2018 •
edited by simonhong
Loading

A setting option to toggle between dark and light mode. Preference value must be available to ThemeProperties::MaybeGetDefaultColorForBraveUi

The setting should be available on all release channels, but defaulted to Light for Release and Beta and Dark for all other.

If there is an active theme installed, this setting could still be enabled since there may be some items that do not come from the theme.
@petemill petemill added this to the Releasable builds 0.55.x milestone Aug 20, 2018
@petemill petemill mentioned this issue Aug 20, 2018
Closed
@simonhong simonhong mentioned this issue Aug 22, 2018
Merged
11 tasks
This was referenced Aug 26, 2018
Merged
Merged
@srirambv
Copy link
Contributor

srirambv commented Sep 21, 2018 •
edited by kjozwiak
Loading

Verification Passed on

Brave 0.55.5 Chromium: 70.0.3538.16 (Official Build) dev (64-bit)
Revision 16ed95b41bb05e565b11fb66ac33c660b721f778-refs/branch-heads/3538@{#306}
OS Linux
Brave 0.55.5 Chromium: 70.0.3538.16 (Official Build) dev (64-bit)
Revision 16ed95b41bb05e565b11fb66ac33c660b721f778-refs/branch-heads/3538@{#306}
OS Windows 7

Went through verification using the following build under macOS 10.13.6 x64 - PASSED

Brave 0.55.6 Chromium: 70.0.3538.16 (Official Build) dev (64-bit)
Revision 16ed95b41bb05e565b11fb66ac33c660b721f778-refs/branch-heads/3538@{#306}
OS Mac OS X

@bbondy bbondy added the QA/Yes label Sep 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@simonhong simonhong

Labels
feature/user-interface All UI related QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes
Projects
None yet
Milestone
0.55.x - Release (Release Channel)
Development

Successfully merging a pull request may close this issue.

Add brave theme option to settings page brave/brave-core
6 participants
@petemill @bbondy @kjozwiak @simonhong @srirambv @btlechowski