Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add toggle for enable_distro_version_check #306

Merged
merged 1 commit into from
Jun 25, 2018
Merged

Conversation

bkero
Copy link
Contributor

@bkero bkero commented Jun 7, 2018

This turns off distro version checks for non-official builds

This is in reference to #305

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed.

Test Plan:

Run a liux build with associated patches

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions

@bbondy
Copy link
Member

bbondy commented Jun 13, 2018

I think I merged something that made this conflict, could you rebase and then ping me on slack?

This turns off distro version checks for non-official builds

This is in reference to brave#305
@yrliou
Copy link
Member

yrliou commented Jun 26, 2018

@bkero Sorry, have to revert this PR in #431 since it caused build error on mac & windows (I didn't check on linux tho)
Please re-PR for this one, thanks.

@kjozwiak kjozwiak mentioned this pull request Sep 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants