Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "add toggle for enable_distro_version_check" #431

Merged
merged 1 commit into from
Jun 26, 2018

Conversation

yrliou
Copy link
Member

@yrliou yrliou commented Jun 26, 2018

Reverts #306
Seeing the error below when building on mac and windows, reverting this PR fixes it.

yrliou@jocelyn-mbpr.local:~/brave$ yarn build
yarn run v1.3.2
$ node ./scripts/commands.js build
update branding...
building brave...
update omaha midl files...
gn gen /Users/yrliou/brave/src/out/Debug --args="safe_browsing_mode=1 root_extra_deps=[\"//brave\"] is_component_build=true proprietary_codecs=true ffmpeg_branding=\"Chrome\" enable_nacl=false enable_widevine=true target_cpu=\"x64\" is_official_build=false is_debug=true dcheck_always_on=true brave_channel=\"\" google_api_key=\"AIzaSyAH90V94EcZBP5oH7oc-mXQrSKgASVxER8\" brave_google_api_key=\"AIzaSyAQfxPJiounkhOjODEO5ZieffeBv6yft2Q\" brave_google_api_endpoint=\"https://www.googleapis.com/geolocation/v1/geolocate?key=\" brave_product_name=\"Brave\" brave_project_name=\"brave\" brave_version_major=\"0\" brave_version_minor=\"50\" brave_version_build=\"5\" safebrowsing_api_endpoint=\"safebrowsing.brave.com\" enable_distro_version_check=undefined mac_signing_identifier=\"\" mac_signing_keychain=\"login\" enable_stripping=false symbol_level=2 enable_profiling=true is_win_fastlink=true cc_wrapper=\"/Users/yrliou/brave/src/brave/script/redirect-cc.py\" "
ERROR at the command-line "--args":1:667: Undefined identifier
safe_browsing_mode=1 root_extra_deps=["//brave"] is_component_build=true proprietary_codecs=true ffmpeg_branding="Chrome" enable_nacl=false enable_widevine=true target_cpu="x64" is_official_build=false is_debug=true dcheck_always_on=true brave_channel="" google_api_key="AIzaSyAH90V94EcZBP5oH7oc-mXQrSKgASVxER8" brave_google_api_key="AIzaSyAQfxPJiounkhOjODEO5ZieffeBv6yft2Q" brave_google_api_endpoint="https://www.googleapis.com/geolocation/v1/geolocate?key=" brave_product_name="Brave" brave_project_name="brave" brave_version_major="0" brave_version_minor="50" brave_version_build="5" safebrowsing_api_endpoint="safebrowsing.brave.com" enable_distro_version_check=undefined mac_signing_identifier="" mac_signing_keychain="login" enable_stripping=false symbol_level=2 enable_profiling=true is_win_fastlink=true cc_wrapper="/Users/yrliou/brave/src/brave/script/redirect-cc.py"
                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                          ^--------
null
null
error Command failed with exit code 1.

cc @bkero

@yrliou yrliou requested a review from bbondy June 26, 2018 17:40
@bbondy bbondy merged commit 9c7ebce into master Jun 26, 2018
@yrliou yrliou deleted the revert-306-distro-check branch June 30, 2018 01:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants