Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Safe Browsing API key #543

Closed
jumde opened this issue Jul 13, 2018 · 5 comments
Closed

Update Safe Browsing API key #543

jumde opened this issue Jul 13, 2018 · 5 comments

Comments

@jumde
Copy link
Contributor

jumde commented Jul 13, 2018

Test Plan

  • Ensure location is shown on maps.google.com when Your location is clicked
  • Navigate to https://testsafebrowsing.appspot.com/ and verify that you see appropriate warnings for different demo pages

--
The dev safe browsing key is limited to 2000 requests per day. Reach out to google to get an updated key with increased request quota per day. cc: @flamsmark

@bbondy bbondy modified the milestones: Backlog, Releasable builds Jul 16, 2018
@tildelowengrimm tildelowengrimm self-assigned this Jul 17, 2018
@bbondy bbondy assigned w0ts0n and RyanJarv and unassigned tildelowengrimm Aug 16, 2018
@w0ts0n
Copy link
Member

w0ts0n commented Aug 17, 2018

Generated the key.
Will be double checking the proxy is working on Monday.
will work with team to make sure the key is used in future CI builds for all channels.

@mbacchi
Copy link
Contributor

mbacchi commented Aug 20, 2018

Note: If using environment variables look for the npm_config_brave_google_api_key and npm_config_brave_google_api_endpoint environment variables as examples of how this works in the Jenkins build jobs currently.

@bbondy
Copy link
Member

bbondy commented Sep 9, 2018

What's the current status on this one @w0ts0n ? Thanks!

@jumde
Copy link
Contributor Author

jumde commented Sep 9, 2018

The new key has been generated, we have upgraded the quota for the key as well. @mbacchi and @RyanJarv are working on setting up key in the proxy. Issue tracked here: https://github.com/brave/devops/issues/208

cc: @tomlowenthal

@srirambv
Copy link
Contributor

srirambv commented Sep 24, 2018

Verification Passed on

Brave 0.55.6 Chromium: 70.0.3538.16 (Official Build) dev (64-bit)
Revision 16ed95b41bb05e565b11fb66ac33c660b721f778-refs/branch-heads/3538@{#306}
OS Linux

Verification PASSED on

Brave 0.55.6 Chromium: 70.0.3538.16 (Official Build) dev (64-bit)
Revision 16ed95b41bb05e565b11fb66ac33c660b721f778-refs/branch-heads/3538@{#306}
OS Windows

Verified passed with

Brave 0.55.6 Chromium: 70.0.3538.16 (Official Build) dev (64-bit)
Revision 16ed95b41bb05e565b11fb66ac33c660b721f778-refs/branch-heads/3538@{#306}
OS Mac OS X

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment