Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ads shows region not supported on upgrade #4154

Closed
ryanml opened this issue Apr 18, 2019 · 1 comment · Fixed by brave/brave-core#2263
Closed

Ads shows region not supported on upgrade #4154

ryanml opened this issue Apr 18, 2019 · 1 comment · Fixed by brave/brave-core#2263

Comments

@ryanml
Copy link
Contributor

ryanml commented Apr 18, 2019

For upgrade paths from <0.63.x, the Ads panel shows that the Region is not supported, but then when the page is reloaded, it correctly does.

It should show that the Region is correctly supported on first load.

@srirambv
Copy link
Contributor

srirambv commented Apr 22, 2019

Verification passed on

Brave 0.63.46 Chromium: 74.0.3729.91 (Official Build) (64-bit)
Revision 03844ed83e02b8add3f4b9cb859a7108d55b2e4d-refs/branch-heads/3729@{#860}
OS Linux

Verification passed on

Brave 0.63.46 Chromium: 74.0.3729.91 (Official Build) (64-bit)
Revision 03844ed83e02b8add3f4b9cb859a7108d55b2e4d-refs/branch-heads/3729@{#860}
OS Windows 10 OS Build 17134.523
  • when upgraded from 0.62.51 to 0.63.46 ensured that Ads is disabled and unsupported message is NOT shown for Ads supported country.
    image
  • when upgraded from 0.62.51 to 0.63.46 ensured that Ads is disabled and unsupported message is shown for non supported country.

image

Verified passed with

Brave 0.63.46 Chromium: 74.0.3729.91 (Official Build) (64-bit)
Revision 03844ed83e02b8add3f4b9cb859a7108d55b2e4d-refs/branch-heads/3729@{#860}
OS Mac OS X
  • Verified test plan from Fix Shows supported region correctly for Ads on first load after upgrade. brave-core#2263

  • Verified that on update from 0.62.51 --> 0.63.46 supported regions (US, Can, UK, FR, DE) had Ads off by default and did not show the 'Sorry' message.
    France
    US

  • Verified that on upgrade from 0.62.51 --> 0.63.46 non-supported regions (tested with Sweden, Australia, Brazil), did not show toggle to enable Ads and did show the 'Sorry' message (in English which is expected at this time).
    Brazil
    Australia

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment