Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Summary is not shown in settings page #2350

Closed
NejcZdovc opened this issue Dec 4, 2018 · 2 comments · Fixed by brave/brave-core#1017
Closed

Summary is not shown in settings page #2350

NejcZdovc opened this issue Dec 4, 2018 · 2 comments · Fixed by brave/brave-core#1017
Assignees
@NejcZdovc
Labels
feature/rewards priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release/blocking release-notes/exclude
Milestone
0.57.x - Release ...

Comments

@NejcZdovc
Copy link
Contributor

Description

Steps to Reproduce

  1. enable rewards
  2. claim grant

Actual result:

You still see Sadly, no tokens yet

Expected result:

You should see summary.

Reproduces how often:

Brave version (brave://version info)

Reproducible on current release:

  • Does it reproduce on brave-browser dev/beta builds?

Website problems only:

  • Does the issue resolve itself when disabling Brave Shields?
  • Is the issue reproducible on the latest version of Chrome?

Additional Information
@NejcZdovc NejcZdovc added feature/rewards priority/P2 A bad problem. We might uplift this to the next planned release. labels Dec 4, 2018
@NejcZdovc NejcZdovc self-assigned this Dec 4, 2018
@NejcZdovc NejcZdovc added this to the 0.57.x - Release milestone Dec 4, 2018
@NejcZdovc
Copy link
Contributor Author

regressed with brave/brave-core#1004

@NejcZdovc NejcZdovc mentioned this issue Dec 4, 2018
Merged
18 tasks
NejcZdovc added a commit to brave/brave-core that referenced this issue Dec 4, 2018
@NejcZdovc
Fixes empty state flow
6cd63da 
Resolves brave/brave-browser#2350
@LaurenWags
Copy link
Member

LaurenWags commented Dec 5, 2018 •
edited by srirambv
Loading

Verified passed with

Brave 0.57.16 Chromium: 71.0.3578.80 (Official Build) (64-bit)
Revision 2ac50e7249fbd55e6f517a28131605c9fb9fe897-refs/branch-heads/3578@{#860}
OS Mac OS X
  • Verified STR from description.
    screen shot 2018-12-05 at 10 45 10 am

Verification Passed on

Brave 0.57.16 Chromium: 71.0.3578.80 (Official Build) (64-bit)
Revision 2ac50e7249fbd55e6f517a28131605c9fb9fe897-refs/branch-heads/3578@{#860}
OS Windows 7

image

Verification passed on

Brave 0.57.17 Chromium: 71.0.3578.80 (Official Build) (64-bit)
Revision 2ac50e7249fbd55e6f517a28131605c9fb9fe897-refs/branch-heads/3578@{#860}
OS Linux

image

@bsclifton bsclifton mentioned this issue Dec 7, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@NejcZdovc NejcZdovc

Labels
feature/rewards priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release/blocking release-notes/exclude
Projects
None yet
Milestone
0.57.x - Release (Release Channel)
Development

Successfully merging a pull request may close this issue.

Fixes empty state flow brave/brave-core
5 participants
@bbondy @NejcZdovc @srirambv @LaurenWags @btlechowski