Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Importing from Brave (Muon version) when it's open will prompt user to close Brave #2334

Closed
bsclifton opened this issue Dec 3, 2018 · 1 comment · Fixed by brave/brave-core#1006

Comments

@bsclifton
Copy link
Member

bsclifton commented Dec 3, 2018

Description

If a user is doing a manual import from Brave (the older Muon version) and they have Muon open, they'll get an importer locked message (see picture under Actual result)

Test plan / Steps to Reproduce

  1. Have an older Brave (release channel) install with profile data
  2. Leave the older Brave open
  3. Launch Brave Core and use Settings => Import to import from Brave (old)
  4. Choose the items and pick Import

Actual result:

brave-import

Expected result:

Instead of Brave, it should probably say Brave (old) (so that user is not confused and doesn't close the current browser (Brave Core)

Reproduces how often:

100%

Brave version (brave://version info)

0.57.12

@LaurenWags
Copy link
Member

LaurenWags commented Dec 5, 2018

Verified passed with

Brave 0.57.16 Chromium: 71.0.3578.80 (Official Build) (64-bit)
Revision 2ac50e7249fbd55e6f517a28131605c9fb9fe897-refs/branch-heads/3578@{#860}
OS Mac OS X
  • Verified STR from description
    screen shot 2018-12-05 at 12 16 34 pm

Verification Passed on

Brave 0.57.16 Chromium: 71.0.3578.80 (Official Build) (64-bit)
Revision 2ac50e7249fbd55e6f517a28131605c9fb9fe897-refs/branch-heads/3578@{#860}
OS Windows
  • Verified the STR from description

image

Verification Passed on

Brave 0.57.16 Chromium: 71.0.3578.80 (Official Build) (64-bit)
Revision 2ac50e7249fbd55e6f517a28131605c9fb9fe897-refs/branch-heads/3578@{#860}
OS Linux

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment