Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated text shown when importer is blocked (because Brave is open). #1006

Merged
merged 1 commit into from
Dec 3, 2018

Conversation

bsclifton
Copy link
Member

@bsclifton bsclifton commented Dec 3, 2018

Intended to make it clear that user should close the OLD version of Brave.

Fixes brave/brave-browser#2334

Text that is updated highlighted in RED (this is the old text)
brave-import

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Verified that these changes build without errors on
    • Windows
    • macOS
    • Linux
  • Verified that these changes pass automated tests (npm test brave_unit_tests && npm test brave_browser_tests) on
    • Windows
    • macOS
    • Linux
  • Ran git rebase master (if needed).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed.
  • Add appropriate QA labels (QA/Yes or QA/No) to include the closed issue in milestone

Test Plan:

See brave/brave-browser#2334

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

@bsclifton bsclifton self-assigned this Dec 3, 2018
Intended to make it clear that user should close the OLD version of Brave.

Fixes brave/brave-browser#2334
@bsclifton bsclifton force-pushed the bsc-import-brave-text-update branch from de9f01d to e7f9f42 Compare December 3, 2018 16:57
@bsclifton bsclifton merged commit 42d75f4 into master Dec 3, 2018
@bsclifton bsclifton deleted the bsc-import-brave-text-update branch December 3, 2018 17:12
bsclifton added a commit that referenced this pull request Dec 3, 2018
Updated text shown when importer is blocked (because Brave is open).
bsclifton added a commit that referenced this pull request Dec 3, 2018
Updated text shown when importer is blocked (because Brave is open).
bsclifton added a commit that referenced this pull request Dec 3, 2018
Updated text shown when importer is blocked (because Brave is open).
@bsclifton
Copy link
Member Author

master 42d75f4
0.59.x f665220
0.58.x e46c1ed
0.57.x 78ad075

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Importing from Brave (Muon version) when it's open will prompt user to close Brave
3 participants