Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rewards Panel height should be dynamic based on content, not fixed #2874

Closed
ryanml opened this issue Jan 9, 2019 · 3 comments · Fixed by brave/brave-core#1895
Closed

Rewards Panel height should be dynamic based on content, not fixed #2874

ryanml opened this issue Jan 9, 2019 · 3 comments · Fixed by brave/brave-core#1895
Assignees
@ryanml
Labels
feature/rewards priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Milestone
0.64.x - Release ...

Comments

@ryanml
Copy link
Contributor

ryanml commented Jan 9, 2019

Currently a minimum height is enforced on the Rewards panel, leading to large white space gaps at the bottom of the Rewards summary view and some publisher views with little information.

The height should become un-fixed with a standard bottom padding under whatever the content is.
@ryanml ryanml added this to the 1.x Backlog milestone Jan 9, 2019
@ryanml ryanml self-assigned this Jan 9, 2019
@NejcZdovc NejcZdovc added the priority/P4 Planned work. We expect to get to it "soon". label Jan 10, 2019
@NejcZdovc NejcZdovc added priority/P2 A bad problem. We might uplift this to the next planned release. and removed priority/P4 Planned work. We expect to get to it "soon". labels Jan 19, 2019
@NejcZdovc NejcZdovc mentioned this issue Jan 23, 2019
Closed
@NejcZdovc
Copy link
Contributor

+1 from #3056

@iccub iccub mentioned this issue Feb 5, 2019
Closed
@rebron rebron removed this from the 1.x Backlog milestone Feb 7, 2019
@NejcZdovc NejcZdovc mentioned this issue Feb 13, 2019
Closed
@NejcZdovc
Copy link
Contributor

+1 from #3332

@ryanml ryanml mentioned this issue Feb 13, 2019
Merged
9 tasks
@ryanml ryanml added this to the 0.64.x - Nightly milestone Mar 7, 2019
@ryanml ryanml mentioned this issue Mar 7, 2019
Merged
19 tasks
ryanml added a commit to brave/brave-core that referenced this issue Mar 8, 2019
@ryanml
Fixes brave/brave-browser#2874, bumps brave-ui
44b4263
ryanml added a commit to brave/brave-core that referenced this issue Mar 13, 2019
@ryanml
Fixes brave/brave-browser#2874, bumps brave-ui
c26f276
ryanml added a commit to brave/brave-core that referenced this issue Mar 18, 2019
@ryanml
Fixes brave/brave-browser#2874, bumps brave-ui
1d8a744
@btlechowski
Copy link

btlechowski commented Apr 25, 2019 •
edited by srirambv
Loading

Verification passed on

Brave 0.64.60 Chromium: 74.0.3729.91 (Official Build) beta (64-bit)
Revision 03844ed83e02b8add3f4b9cb859a7108d55b2e4d-refs/branch-heads/3729@{#860}
OS Windows 10 OS Build 17134.523

Used test plan brave/brave-core#1895

Verified passed with

Brave 0.64.62 Chromium: 74.0.3729.108 (Official Build) beta(64-bit)
Revision daaff52abef89988bf2a26091062160b1482b108-refs/branch-heads/3729@{#901}
OS Mac OS X
Brave 0.64.72 Chromium: 74.0.3729.131 (Official Build) beta(64-bit)
Revision 518a41c1fa7ce1c8bb5e22346e82e42b4d76a96f-refs/branch-heads/3729@{#954}
OS Linux

@kjozwiak kjozwiak mentioned this issue May 8, 2019
Closed
77 tasks
@kjozwiak kjozwiak mentioned this issue May 14, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ryanml ryanml

Labels
feature/rewards priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Projects
None yet
Milestone
0.64.x - Release (Release Channel)
Development

Successfully merging a pull request may close this issue.

Making Rewards panel height dynamic brave/brave-core
7 participants
@kjozwiak @rebron @ryanml @NejcZdovc @srirambv @LaurenWags @btlechowski