Internal URLs imported from Muon fail to resolve

[garrettr]

Test Plan

brave/brave-core#1021

Description

Follow-up for #998 (comment).

The windows/tabs importer exactly re-creates the windows and tabs that were open in Muon in b-c. If any of the open tabs were showing a Muon internal URL (e.g. about:preferences#payments for Brave Payments, chrome-extension://... for PDFs rendered by pdf.js), it probably won't resolve in b-c because most of the internal URLs have changed.

A small subset of internal URLs, for example about:history, resolve correctly in both Muon and b-c.

Steps to Reproduce

1. In Muon, open one or more tabs and look up an internal URL, e.g. about:brave.
2. Quit Muon and start brave-core.
3. Import open windows/tabs from Muon into brave-core (follow the test plan from Import open windows and tabs from legacy Brave brave-core#981).

Actual result:

Expected result:

One of the two following scenarios should be implemented:

1. Internal URLs from Muon should be filtered during import and should not be loaded in brave-core
2. Internal URLs from Muon should be rewritten to their brave-core equivalents during import so they will load the expected page. This may not be possible for all Muon internal URLs.

Reproduces how often:

Easily reproduced.

[LaurenWags]

Following test plan from brave/brave-core#1021, my pinned tab with a PDF is imported (and opens fine) in b-c, but the normal tab which had a pdf is not imported into b-c. Is this expected?
This is muon prior to b-c import:

This is b-c after import from muon. I was expecting that the pinned 'PDFjs' tab wouldn't be there.

[bsclifton]

@garrettr I believe the filtering logic might not be applying to pinned tabs

[garrettr]

@bsclifton Filtering logic should be applied in ParsePinnedTabs here.

[LaurenWags]

Verified passed with

Brave	0.57.16 Chromium: 71.0.3578.80 (Official Build) (64-bit)
Revision	2ac50e7249fbd55e6f517a28131605c9fb9fe897-refs/branch-heads/3578@{#860}
OS	Mac OS X

• Verified with test plan in Filter internal URLs when importing Muon tabs brave-core#1021
• Encountered and logged pinned PDF tab imported from muon not filtered out - follow up to 2361 #2376 based on what I saw in Internal URLs imported from Muon fail to resolve #2361 (comment)

Verification Passed on

Brave	0.57.17 Chromium: 71.0.3578.80 (Official Build) (64-bit)
Revision	2ac50e7249fbd55e6f517a28131605c9fb9fe897-refs/branch-heads/3578@{#860}
OS	Windows 7

Encounter an issue with pdf link: #2376 (comment)

Brave	0.57.17 Chromium: 71.0.3578.80 (Official Build) (64-bit)
Revision	2ac50e7249fbd55e6f517a28131605c9fb9fe897-refs/branch-heads/3578@{#860}
OS	Linux

• Linux specific issue pinned PDF tab imported from muon not filtered out - follow up to 2361 #2376 (comment)