clicking "Learn More" on the "Tips have changed" notification doesn't display the modal

[kjozwiak]

Description

Clicking on the Learn More button under the Your pinned sites have been moved to monthly tips notification doesn't display the modal that explains why users are seeing recurring tips. You'll only get the following error in the console:

[45881:775:1205/003330.843971:INFO:CONSOLE(2601)] "Alert closed", source: chrome://rewards/brave_rewards.js (2601)

Steps to Reproduce

1. ensure that you have a profile under muon that you can import into b-c
2. launch 0.57.16 Chromium: 71.0.3578.80 using --upgrade-from-muon
3. once 0.57.16 Chromium: 71.0.3578.80

Actual result:

Expected result:

Modal should appear that explains why pinned sites where converted to recurring tips.

Reproduces how often:

100% using the above STR.

Brave version (brave://version info)

Brave	0.57.16 Chromium: 71.0.3578.80 (Official Build) (64-bit)
Revision	2ac50e7249fbd55e6f517a28131605c9fb9fe897-refs/branch-heads/3578@{#860}
OS	Mac OS X

[bsclifton]

This is fixed in the 0.57.x branch after merging brave/brave-core#1022... but let's leave open as this is not contained in a build yet

We would need to create a RC4 in order to get this

[bsclifton]

Fixed with RC4 😄👍

[LaurenWags]

Verified passed with

Brave	0.57.17 Chromium: 71.0.3578.80 (Official Build) (64-bit)
Revision	2ac50e7249fbd55e6f517a28131605c9fb9fe897-refs/branch-heads/3578@{#860}
OS	Mac OS X

• Verified STR from description
  

Verification Passed on

Brave	0.57.17 Chromium: 71.0.3578.80 (Official Build) (64-bit)
Revision	2ac50e7249fbd55e6f517a28131605c9fb9fe897-refs/branch-heads/3578@{#860}
OS	Windows 7

Verification passed on

Brave	0.57.17 Chromium: 71.0.3578.80 (Official Build) (64-bit)
Revision	2ac50e7249fbd55e6f517a28131605c9fb9fe897-refs/branch-heads/3578@{#860}
OS	Linux