Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When choosing to save password, passwords are not being saved #624

Closed
bsclifton opened this issue Jul 22, 2018 · 2 comments
Closed

When choosing to save password, passwords are not being saved #624

bsclifton opened this issue Jul 22, 2018 · 2 comments
Labels
closed/duplicate Issue has already been reported feature/password-manager

Comments

@bsclifton
Copy link
Member

bsclifton commented Jul 22, 2018

Description

Saving passwords with the built in manager does not work. Possibly related to #563

Found looking to see if brave/browser-laptop#1857 is an issue in Brave Core

Steps to Reproduce

  1. Visit a site which requires credentials to login (ex: https://trac.torproject.org/projects/tor/login)
  2. Login
  3. Verify you see prompt to save
  4. Click Save (you may need to dismiss the confirmation Sign-In modal by clicking the X in top right)
  5. Visit chrome://settings/passwords OR click the key in the URL bar
  6. Notice that no password was actually saved

Actual result:

password-not-saving

Expected result:

Passwords should be saved

Reproduces how often:

Brave version (about:brave info)

Reproducible on current release:

Website problems only:

  • Does the issue resolve itself when disabling Brave Shields?
  • Is the issue reproducible on the latest version of Chrome?

Additional Information

@bsclifton bsclifton added this to the Backlog milestone Jul 22, 2018
@srirambv
Copy link
Contributor

Works for me on Windows

@rebron rebron modified the milestone: 1.x Backlog Feb 7, 2019
@bsclifton
Copy link
Member Author

Closing in favor of #4061

I haven't experienced this in a very long time personally

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed/duplicate Issue has already been reported feature/password-manager
Projects
None yet
Development

No branches or pull requests

3 participants